Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O3-1661: mostRecentObsValueBefore data source in AMPATH forms. #20

Closed
wants to merge 1 commit into from

Conversation

hadijahkyampeire
Copy link
Contributor

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.

Summary

  • Adds a data source that has a function that returns all obs values before a given date.

Screenshots

This is an example of the logs showing all obs/concepts and filtered ones based on the date supplied
Screenshot 2022-12-07 at 15 34 50

Issue

mostRecentObsValueBefore data source in AMPATH forms

Other

  • I used the mock-obs, and I wasn't sure of the date format which will be passed, so this is not yet perfect, it is based on assumptions of a date format and some hardcording.

@ibacher
Copy link
Member

ibacher commented Dec 7, 2022

So there are two "apps" in this repository, a simple app for testing things and the actual engine. This adds a data source to the testing app. I'm not sure I see why we would merge this PR as-is? (The testing app isn't actually used in the patient chart, so this doesn't add any real functionality; I'm also unclear how the proposed data source is supposed to function in the real world?).

I'd assume that the function can be passed a real Javascript date, so the string mangling shouldn't be necessary...

@hadijahkyampeire
Copy link
Contributor Author

Closing this, the work to cover this has been moved to patient chart in this PR

@ibacher ibacher deleted the hadijah/03-1661 branch February 15, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants