feat:(form-app) mostRecentObsValueBefore data source in form-entry (O3-1661) #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadijahkyampeire
requested review from
FlorianRappl,
ibacher,
rbuisson and
reagan-meant
Closed
1 task
|
Size Change: +514 B (0%) Total Size: 5.72 MB
ℹ️ View Unchanged
|
ibacher
requested changes
Dec 13, 2022
There was a problem hiding this comment.
Thanks Hadijah! Some good stuff in here. I think you're right that we need the patient UUID as a parameter, so the function signature should be something like:
getMostRecentObsValues(patient: string, concepts: string[])But I'd probably do something like this:
getMostRecentObsValues(patient: string, date: Date, concepts: string[]);Or:
getMostRecentObsValues(patient: string, { date: Date, concepts: string[] });
packages/esm-form-entry-app/src/app/form-creation/form-creation.service.ts
Outdated
Show resolved
Hide resolved
packages/esm-form-entry-app/src/app/form-creation/form-creation.service.ts
Outdated
Show resolved
Hide resolved
packages/esm-form-entry-app/src/app/form-creation/form-creation.service.ts
Outdated
Show resolved
Hide resolved
packages/esm-form-entry-app/src/app/form-creation/form-creation.service.ts
Outdated
Show resolved
Hide resolved
packages/esm-form-entry-app/src/app/form-data-source/form-data-source.service.ts
Outdated
Show resolved
Hide resolved
packages/esm-form-entry-app/src/app/form-data-source/form-data-source.service.ts
Outdated
Show resolved
Hide resolved
packages/esm-form-entry-app/src/app/openmrs-api/obs-resource.service.ts
Outdated
Show resolved
Hide resolved
packages/esm-form-entry-app/src/app/form-data-source/form-data-source.service.ts
Outdated
Show resolved
Hide resolved
packages/esm-form-entry-app/src/app/form-data-source/form-data-source.service.ts
Outdated
Show resolved
Hide resolved
packages/esm-form-entry-app/src/app/form-data-source/form-data-source.service.ts
Outdated
Show resolved
Hide resolved
packages/esm-form-entry-app/src/app/openmrs-api/concept-resource.service.ts
Outdated
Show resolved
Hide resolved
packages/esm-form-entry-app/src/app/openmrs-api/obs-resource.service.ts
Outdated
Show resolved
Hide resolved
packages/esm-form-entry-app/src/app/openmrs-api/obs-resource.service.ts
Outdated
Show resolved
Hide resolved
|
@ibacher @FlorianRappl I have implemented the requested changes, please take another look. |
denniskigen
reviewed
Dec 15, 2022
packages/esm-form-entry-app/src/app/openmrs-api/obs-resource.service.ts
Outdated
Show resolved
Hide resolved
|
Thanks @ibacher for the commits |
|
Thanks @FlorianRappl for the approval, I guess we shall merge it after @ibacher and I test the data source in a sample form |
|
Thanks, @FlorianRappl for the approval, I guess we shall merge it after @ibacher and I test the data source in a sample form |
1 task
| private extractMostRecentObsConceptIds(questions: Array<Questions>, concepts: Set<string>) { | ||
| for (const question of questions) { | ||
| const useMostRecentValue = question.questionOptions?.useMostRecentValue ?? false; | ||
| if (useMostRecentValue === 'true' || (typeof useMostRecentValue === 'boolean' && useMostRecentValue)) { |
There was a problem hiding this comment.
@ibacher is this going to be a string named "true" or a boolean true
There was a problem hiding this comment.
Or this is an angular syntax 🤔 ?
There was a problem hiding this comment.
The idea is to support both, since that's what is used elsewhere in the form engine.
There was a problem hiding this comment.
okay, thanks for the polish, it looks much better and makes a lot of sense now 👍 .
1 task
ibacher
approved these changes
Dec 20, 2022
ibacher
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Screenshots
Related Issue
https://issues.openmrs.org/browse/O3-1661