Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the create_theme script #1913

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Fix the create_theme script #1913

merged 2 commits into from
Jan 10, 2024

Conversation

jwkaltz
Copy link
Member

@jwkaltz jwkaltz commented Dec 26, 2023

Fixes #1562

Example usage (when running in local development setup):

.venv/bin/create_theme_tables --configuration pyramid_oereb.yml --theme ch.Nutzungsplanung --sql-file test.sql

Note that this will only work with SQL file as output, not as direct database statement writing. Otherwise, some code refactoring would be required and I think direct database statement writing is not a good idea anyway when using a script in this way.

Copy link

codecov bot commented Dec 26, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (0e166c3) 80.59% compared to head (1a62ff8) 80.57%.
Report is 13 commits behind head on master.

Files Patch % Lines
...yramid_oereb/contrib/data_sources/create_tables.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1913      +/-   ##
==========================================
- Coverage   80.59%   80.57%   -0.02%     
==========================================
  Files         125      125              
  Lines        5266     5267       +1     
==========================================
  Hits         4244     4244              
- Misses       1022     1023       +1     
Flag Coverage Δ
unittests 80.57% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@michmuel michmuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks. I have just one question.

@jwkaltz jwkaltz requested a review from michmuel January 8, 2024 07:03
@jwkaltz jwkaltz merged commit 12a7ac6 into master Jan 10, 2024
9 of 11 checks passed
@jwkaltz jwkaltz deleted the fix_create_theme_script branch January 10, 2024 07:52
jwkaltz added a commit that referenced this pull request Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create_theme_tables does not work
2 participants