Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify create_tables script #1914

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Conversation

jwkaltz
Copy link
Member

@jwkaltz jwkaltz commented Dec 26, 2023

Fixes #1563

See also comment in #1913 (comment)

Copy link

codecov bot commented Dec 26, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (0e166c3) 80.59% compared to head (af422fc) 80.59%.

Files Patch % Lines
...reb/contrib/data_sources/standard/create_tables.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1914   +/-   ##
=======================================
  Coverage   80.59%   80.59%           
=======================================
  Files         125      125           
  Lines        5266     5266           
=======================================
  Hits         4244     4244           
  Misses       1022     1022           
Flag Coverage Δ
unittests 80.59% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jwkaltz jwkaltz merged commit aad11b5 into master Jan 8, 2024
10 of 11 checks passed
@jwkaltz jwkaltz deleted the clarify_create_tables_script branch January 8, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create_standard_tables only works with sql_file
2 participants