Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade GitHub Actions to use newer version of NodeJS/NPM #918

Closed
dlabordus opened this issue Aug 3, 2022 · 0 comments · Fixed by #1192
Closed

Upgrade GitHub Actions to use newer version of NodeJS/NPM #918

dlabordus opened this issue Aug 3, 2022 · 0 comments · Fixed by #1192
Labels
Kind: Maintenance Maintaining tasks within OpenSCD

Comments

@dlabordus
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The package-lock.json file is created using version 2, this means at least version 7 of NPM.
The build is using NodeJS 14, but if a developer is also using that version the package-lock.json will be downgraded to version 1.

Describe the solution you'd like
Use a newer version of NodeJS (for instance the current stable version 18 with NPM version 8) in the GitHub actions.
And also update documentation to indicate that developers should use this version.

Requirements
GitHub Action are using a newer version of NodeJS to build the project.
@dlabordus dlabordus added the Kind: Maintenance Maintaining tasks within OpenSCD label Aug 3, 2022
@dlabordus dlabordus mentioned this issue Aug 3, 2022
Open
apupier added a commit to apupier/open-scd that referenced this issue Mar 3, 2023
@apupier
chore: Update Node from 14.x to 18.x
188613f 
- updated GitHub Actions
- provide information in readme on the version to use

fixes openscd#918

Signed-off-by: Aurélien Pupier <[email protected]>
apupier added a commit to apupier/open-scd that referenced this issue Mar 3, 2023
@apupier
chore: Update Node from 14.x to 18.x
22742d2 
- updated GitHub Actions
- provide information in readme on the version to use

fixes openscd#918

Signed-off-by: Aurélien Pupier <[email protected]>
@apupier apupier mentioned this issue Mar 3, 2023
Merged
ca-d pushed a commit to apupier/open-scd that referenced this issue Mar 7, 2023
@apupier @ca-d
chore: Update Node from 14.x to 18.x
da1bac0 
- updated GitHub Actions
- provide information in readme on the version to use

fixes openscd#918

Signed-off-by: Aurélien Pupier <[email protected]>
danyill pushed a commit that referenced this issue Mar 13, 2023
@apupier @ca-d @Sander3003
chore(update-actions): Update Node from 14.x to 18.x (#1192)
5bded32 
* chore: Update Node from 14.x to 18.x

- updated GitHub Actions
- provide information in readme on the version to use

fixes #918

Signed-off-by: Aurélien Pupier <[email protected]>

* fix: explicitly depend on source-map

Adds a "source-map" dev dependency to package.json to fix the version to
one where mozilla/source-map#432 is not an
issue.

---------

Signed-off-by: Aurélien Pupier <[email protected]>
Co-authored-by: Christian Dinkel <[email protected]>
Co-authored-by: Sander Jansen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Kind: Maintenance Maintaining tasks within OpenSCD
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(update-actions): Update Node from 14.x to 18.x apupier/open-scd
1 participant
@dlabordus