chore(update-actions): Update Node from 14.x to 18.x #1192
Conversation
- updated GitHub Actions - provide information in readme on the version to use fixes openscd#918 Signed-off-by: Aurélien Pupier <[email protected]>
There was a problem hiding this comment.
LGTM, thank you for the contribution and welcome to the project!
If you want some help overcoming our desperately lacking developer documentation, please feel free to join the #open-scd channel on lfenergy.slack.com and say hi! 👋
Adds a "source-map" dev dependency to package.json to fix the version to one where mozilla/source-map#432 is not an issue.
|
I'm sorry for pushing directly to your fork, I intended to push to my own fork and send a pull request describing an issue with an older version of some upstream development dependency and the new node version. I was surprised to find that I could simply push the change to your fork. |
No problem, I always |
|
hey @apupier - around here with approval, contributors merge their own PRs (not, I think, that we told anyone that 😉). I'd be keen for you to merge this when you can as it would be convenient for me too. Thanks for this PR. |
|
I do not have rights to merge it:
|
Oh sorry, how annoying. I'll do it. |
danyill
changed the title
fixes #918