Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Workspace]DQC can not be assigned to a workspace due to validation #9259

Merged
merged 9 commits into from
Jan 24, 2025
Merged

[Workspace]DQC can not be assigned to a workspace due to validation #9259

merged 9 commits into from
Jan 24, 2025

Conversation

Qxisylolo
Copy link
Contributor

@Qxisylolo Qxisylolo commented Jan 23, 2025 •
edited
Loading

Description

Fix bug: In a workspace, and try to associate direct query connection, it will fail to get dqc and return 403 error

Issues Resolved

Issue: #9257

Screenshot

2025-01-23.14.31.09.mov

Testing the changes

Changelog

  • fix: DQC can not be assigned to a workspace due to validation

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

opensearch-changeset-bot bot added a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Jan 23, 2025
@opensearch-changeset-bot
Changeset file for PR opensearch-project#9259 created/updated
ec0ea65
@Qxisylolo Qxisylolo force-pushed the fix/permission_for_dqc branch from ec0ea65 to d72a2c6 Compare January 23, 2025 07:05
opensearch-changeset-bot bot added a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Jan 23, 2025
@opensearch-changeset-bot
Changeset file for PR opensearch-project#9259 created/updated
b0371f8
@Qxisylolo Qxisylolo marked this pull request as ready for review January 23, 2025 07:16
@codecov Codecov
Copy link

codecov bot commented Jan 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.69%. Comparing base (0be70a7) to head (9e6b07d).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9259      +/-   ##
==========================================
+ Coverage   61.68%   61.69%   +0.01%     
==========================================
  Files        3816     3816              
  Lines       91693    91693              
  Branches    14516    14516              
==========================================
+ Hits        56557    56569      +12     
+ Misses      31510    31498      -12     
  Partials     3626     3626
Flag Coverage Δ
Linux_1 29.04% <50.00%> (ø)
Linux_2 56.46% <100.00%> (ø)
Linux_3 39.08% <0.00%> (?)
Linux_4 28.97% <0.00%> (ø)
Windows_1 29.07% <50.00%> (+0.01%) ⬆️
Windows_2 56.41% <100.00%> (ø)
Windows_3 39.09% <0.00%> (ø)
Windows_4 28.97% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Qxisylolo and others added 5 commits January 24, 2025 10:56
@Qxisylolo Qxisylolo force-pushed the fix/permission_for_dqc branch from 071f0bb to 859e540 Compare January 24, 2025 03:03
@Qxisylolo
a little fix
63752cf 
Signed-off-by: Qxisylolo <[email protected]>
@Qxisylolo
use PrependOptions
a04b6ca 
Signed-off-by: Qxisylolo <[email protected]>
@Qxisylolo
typo
58b8770 
Signed-off-by: Qxisylolo <[email protected]>
@Qxisylolo
fix test
9e6b07d 
Signed-off-by: Qxisylolo <[email protected]>
SuZhou-Joe
SuZhou-Joe approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@SuZhou-Joe SuZhou-Joe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, LGTM

@Hailong-am Hailong-am merged commit c91df47 into opensearch-project:main Jan 24, 2025
74 of 75 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 24, 2025
@github-actions @opensearch-changeset-bot
[Workspace]DQC can not be assigned to a workspace due to validation (#…
aa1788d 
…9259)

* new try

Signed-off-by: Qxisylolo <[email protected]>

* Changeset file for PR #9259 created/updated

* correction

Signed-off-by: Qxisylolo <[email protected]>

* use header

Signed-off-by: Qxisylolo <[email protected]>

* fix test

Signed-off-by: Qxisylolo <[email protected]>

* a little fix

Signed-off-by: Qxisylolo <[email protected]>

* use PrependOptions

Signed-off-by: Qxisylolo <[email protected]>

* typo

Signed-off-by: Qxisylolo <[email protected]>

* fix test

Signed-off-by: Qxisylolo <[email protected]>

---------

Signed-off-by: Qxisylolo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit c91df47)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jan 24, 2025
Merged
SuZhou-Joe pushed a commit that referenced this pull request Jan 24, 2025
@opensearch-trigger-bot @github-actions @opensearch-changeset-bot
[Workspace]DQC can not be assigned to a workspace due to validation (#…
28732f7 
…9259) (#9271)

* new try



* Changeset file for PR #9259 created/updated

* correction



* use header



* fix test



* a little fix



* use PrependOptions



* typo



* fix test



---------



(cherry picked from commit c91df47)

Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hailong-am Hailong-am Hailong-am approved these changes

@SuZhou-Joe SuZhou-Joe SuZhou-Joe approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees
No one assigned
Labels
all-star-contributor backport 2.x v2.19.0 workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Qxisylolo @SuZhou-Joe @Hailong-am