Add indexing,search BwC tests for type mapping removal changes #2601

kotwanikunal · 2022-03-25T19:00:46Z

Signed-off-by: Kunal Kotwani [email protected]

Description

Add backwards compatibility tests for testing type mapping changes from OS2.0

Issues Resolved

Add new tests to verify bwc scenarios #2240

Check List

New functionality includes testing.
All tests pass
New functionality has been documented.
New functionality has javadoc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Kunal Kotwani <[email protected]>

opensearch-ci-bot · 2022-03-25T19:41:04Z

✅ Gradle Check success 0ce7789
Log 3766

Reports 3766

qa/rolling-upgrade/src/test/java/org/opensearch/upgrades/IndexingIT.java

opensearch-ci-bot · 2022-03-28T17:19:33Z

❌ Gradle Check failure f53b5cdc8ba9453bb7d558bf009c446adfeba7a4
Log 3808

Reports 3808

dreamer-89 · 2022-03-28T17:25:37Z

Gradle check failure. The resp object from _search action seems to be null

Map<String, Object> resp = entityAsMap(client().performRequest(new Request("GET", "/" + index + "/_search"))); assertNoFailures(resp);

Failure stacktrace.

> Task :qa:rolling-upgrade:v1.3.1#upgradedClusterTest

REPRODUCE WITH: ./gradlew ':qa:rolling-upgrade:v1.3.1#upgradedClusterTest' --tests "org.opensearch.upgrades.IndexingIT.testTypeRemovalIndexing" -Dtests.seed=A00E1BB3E539D943 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=en-PH -Dtests.timezone=Europe/Helsinki -Druntime.java=17

org.opensearch.upgrades.IndexingIT > testTypeRemovalIndexing FAILED
    java.lang.ExceptionInInitializerError
        at __randomizedtesting.SeedInfo.seed([A00E1BB3E539D943:21AD8924DEBE40D]:0)
        at org.opensearch.upgrades.IndexingIT.assertNumHits(IndexingIT.java:307)
        at org.opensearch.upgrades.IndexingIT.testTypeRemovalIndexing(IndexingIT.java:232)

        Caused by:
        java.lang.IllegalArgumentException: Failed to parse value [null] as only [true] or [false] are allowed.
            at org.opensearch.common.Booleans.parseBoolean(Booleans.java:86)
            at org.opensearch.upgrades.AbstractFullClusterRestartTestCase.<clinit>(AbstractFullClusterRestartTestCase.java:45)
            ... 2 more

kotwanikunal · 2022-03-28T17:30:15Z

Gradle check failure. The resp object from _search action seems to be null

Map<String, Object> resp = entityAsMap(client().performRequest(new Request("GET", "/" + index + "/_search"))); assertNoFailures(resp);

Failure stacktrace.

> Task :qa:rolling-upgrade:v1.3.1#upgradedClusterTest

REPRODUCE WITH: ./gradlew ':qa:rolling-upgrade:v1.3.1#upgradedClusterTest' --tests "org.opensearch.upgrades.IndexingIT.testTypeRemovalIndexing" -Dtests.seed=A00E1BB3E539D943 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=en-PH -Dtests.timezone=Europe/Helsinki -Druntime.java=17

org.opensearch.upgrades.IndexingIT > testTypeRemovalIndexing FAILED
    java.lang.ExceptionInInitializerError
        at __randomizedtesting.SeedInfo.seed([A00E1BB3E539D943:21AD8924DEBE40D]:0)
        at org.opensearch.upgrades.IndexingIT.assertNumHits(IndexingIT.java:307)
        at org.opensearch.upgrades.IndexingIT.testTypeRemovalIndexing(IndexingIT.java:232)

        Caused by:
        java.lang.IllegalArgumentException: Failed to parse value [null] as only [true] or [false] are allowed.
            at org.opensearch.common.Booleans.parseBoolean(Booleans.java:86)
            at org.opensearch.upgrades.AbstractFullClusterRestartTestCase.<clinit>(AbstractFullClusterRestartTestCase.java:45)
            ... 2 more

It does pass on my local. Taking a look at this.

Signed-off-by: Kunal Kotwani <[email protected]>

opensearch-ci-bot · 2022-03-28T21:06:58Z

❌ Gradle Check failure 92bc227
Log 3829

Reports 3829

dreamer-89 · 2022-03-28T21:11:18Z

REPRODUCE WITH: ./gradlew ':server:test' --tests "org.opensearch.index.ShardIndexingPressureConcurrentExecutionTests.testReplicaThreadedUpdateToShardLimitsAndRejections" -Dtests.seed=93564D929C648708 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=fr-LU -Dtests.timezone=Etc/GMT-1 -Druntime.java=17

org.opensearch.index.ShardIndexingPressureConcurrentExecutionTests > testReplicaThreadedUpdateToShardLimitsAndRejections FAILED
    java.lang.AssertionError: expected null, but was:<org.opensearch.index.stats.IndexingPressurePerShardStats@76470d6e>
        at __randomizedtesting.SeedInfo.seed([93564D929C648708:9CCE7963BCE5A99D]:0)
        at org.junit.Assert.fail(Assert.java:89)
        at org.junit.Assert.failNotNull(Assert.java:756)
        at org.junit.Assert.assertNull(Assert.java:738)
        at org.junit.Assert.assertNull(Assert.java:748)
        at org.opensearch.index.ShardIndexingPressureConcurrentExecutionTests.testReplicaThreadedUpdateToShardLimitsAndRejections(ShardIndexingPressureConcurrentExecutionTests.java:336)

dreamer-89 · 2022-03-28T21:11:49Z

Failure doesn't belong to code changes. Re-firing

dreamer-89 · 2022-03-28T21:11:56Z

start gradle check

opensearch-ci-bot · 2022-03-28T21:40:54Z

❌ Gradle Check failure 92bc227
Log 3831

Reports 3831

kotwanikunal · 2022-03-28T21:56:39Z

Another unrelated test failure -

REPRODUCE WITH: ./gradlew ':qa:remote-clusters:integTest' --tests "org.opensearch.cluster.remote.test.RemoteClustersIT.testHAProxyModeConnectionWorks" -Dtests.seed=DB8B6E2943623CFB -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=mt-MT -Dtests.timezone=SystemV/AST4 -Druntime.java=17

org.opensearch.cluster.remote.test.RemoteClustersIT > testHAProxyModeConnectionWorks FAILED
    java.lang.AssertionError
        at __randomizedtesting.SeedInfo.seed([DB8B6E2943623CFB:DCFDBBE278E44AA6]:0)
        at org.junit.Assert.fail(Assert.java:87)
        at org.junit.Assert.assertTrue(Assert.java:42)
        at org.junit.Assert.assertTrue(Assert.java:53)
        at org.opensearch.cluster.remote.test.RemoteClustersIT.testHAProxyModeConnectionWorks(RemoteClustersIT.java:125)

kotwanikunal · 2022-03-28T21:57:07Z

start gradle check

dreamer-89 · 2022-03-28T22:06:28Z

There is already issue opened for testHAProxyModeConnectionWorks

#1703

opensearch-ci-bot · 2022-03-28T22:25:03Z

❌ Gradle Check failure 92bc227
Log 3833

Reports 3833

Signed-off-by: Kunal Kotwani <[email protected]>

opensearch-ci-bot · 2022-03-30T17:51:25Z

❌ Gradle Check failure 93a7cdb
Log 3898

Reports 3898

opensearch-ci-bot · 2022-03-30T18:17:33Z

❌ Gradle Check failure 6a15e42
Log 3899

Reports 3899

kotwanikunal · 2022-03-30T18:20:38Z

Updated the code for failing test:

REPRODUCE WITH: ./gradlew ':qa:rolling-upgrade:v1.4.0#oldClusterTest' --tests "org.opensearch.upgrades.IndexingIT.testTypeRemovalIndexing" -Dtests.seed=34468A3B522FE11F -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=ja-JP -Dtests.timezone=Europe/Lisbon -Druntime.java=17
  2> org.opensearch.client.WarningFailureException: method [PUT], host [http://127.0.0.1:42291], URI [/_template/test_template?include_type_name=true], status line [HTTP/1.1 200 OK]
    Warnings: [[types removal] Specifying include_type_name in put index template requests is deprecated. The parameter will be removed in the next major version., Deprecated field [template] used, replaced by [index_patterns]]
    {"acknowledged":true}
        at __randomizedtesting.SeedInfo.seed([34468A3B522FE11F:9652491AFAFDDC51]:0)
        at app//org.opensearch.client.RestClient.convertResponse(RestClient.java:346)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:320)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:295)
        at app//org.opensearch.upgrades.IndexingIT.createTemplate(IndexingIT.java:367)
        at app//org.opensearch.upgrades.IndexingIT.testTypeRemovalIndexing(IndexingIT.java:215)
  1> [2022-03-30T18:59:13,731][INFO ][o.o.u.IndexingIT         ] [testIndexing] before test
  1> [2022-03-30T18:59:19,444][INFO ][o.o.u.IndexingIT         ] [testIndexing] after test
  1> [2022-03-30T18:59:19,458][INFO ][o.o.u.IndexingIT         ] [testAutoIdWithOpTypeCreate] before test
  1> [2022-03-30T18:59:20,799][INFO ][o.o.u.IndexingIT         ] [testAutoIdWithOpTypeCreate] after test
  2> NOTE: leaving temporary files on disk at: /var/CITOOL/workflow/OpenSearch_CI/PR_Checks/Gradle_Check/search/qa/rolling-upgrade/build/testrun/v1.4.0#oldClusterTest/temp/org.opensearch.upgrades.IndexingIT_34468A3B522FE11F-001
  2> NOTE: test params are: codec=Asserting(Lucene91): {}, docValues:{}, maxPointsInLeafNode=1071, maxMBSortInHeap=6.4225682890862625, sim=Asserting(RandomSimilarity(queryNorm=true): {}), locale=ja-JP, timezone=Europe/Lisbon
  2> NOTE: Linux 5.13.0-1014-aws amd64/Eclipse Adoptium 17.0.2 (64-bit)/cpus=72,threads=1,free=448939824,total=536870912
  2> NOTE: All tests run in this JVM: [IndexingIT]

opensearch-ci-bot · 2022-03-30T18:44:44Z

❌ Gradle Check failure 88d92c887669d8a3e5660d0d49e7e5d6720f61b2
Log 3902

Reports 3902

opensearch-ci-bot · 2022-03-30T19:38:44Z

❌ Gradle Check failure 90a3fdd6f5798b694e37cf653fdf9817000b3565
Log 3911

Reports 3911

dreamer-89 · 2022-03-31T02:22:31Z

start gradle check

opensearch-ci-bot · 2022-04-06T04:41:41Z

✅ Gradle Check success 7aec869316b11b9f53b343390bf8a1d9258e8507
Log 4246

Reports 4246

Signed-off-by: Kunal Kotwani <[email protected]>

opensearch-ci-bot · 2022-04-06T17:43:37Z

❌ Gradle Check failure fdbf247
Log 4253

Reports 4253

kotwanikunal · 2022-04-06T17:53:31Z

Unrelated test failure:

REPRODUCE WITH: ./gradlew ':plugins:repository-azure:internalClusterTest' --tests "org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.testSnapshotWithLargeSegmentFiles" -Dtests.seed=A319369D69EB94AA -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=es-DO -Dtests.timezone=America/Fort_Nelson -Druntime.java=17

org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests > testSnapshotWithLargeSegmentFiles FAILED
    java.lang.AssertionError: 
    Expected: a value greater than <0>
         but: <0> was equal to <0>
        at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
        at org.junit.Assert.assertThat(Assert.java:964)
        at org.junit.Assert.assertThat(Assert.java:930)
        at org.opensearch.repositories.blobstore.OpenSearchBlobStoreRepositoryIntegTestCase.assertSuccessfulRestore(OpenSearchBlobStoreRepositoryIntegTestCase.java:532)
        at org.opensearch.repositories.blobstore.OpenSearchBlobStoreRepositoryIntegTestCase.assertSuccessfulRestore(OpenSearchBlobStoreRepositoryIntegTestCase.java:528)
        at org.opensearch.repositories.blobstore.OpenSearchMockAPIBasedRepositoryIntegTestCase.testSnapshotWithLargeSegmentFiles(OpenSearchMockAPIBasedRepositoryIntegTestCase.java:182)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:568)
        at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1750)
        at com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:938)
        at com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:974)
        at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:988)
        at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
        at org.junit.rules.RunRules.evaluate(RunRules.java:20)
        at org.apache.lucene.tests.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:44)
        at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
        at org.apache.lucene.tests.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:45)
        at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
        at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
        at org.junit.rules.RunRules.evaluate(RunRules.java:20)
        at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
        at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:368)
        at com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:817)
        at com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:468)
        at com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:947)
        at com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:832)
        at com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:883)
        at com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:894)
        at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
        at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
        at org.apache.lucene.tests.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:38)
        at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
        at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
        at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
        at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
        at org.apache.lucene.tests.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
        at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
        at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
        at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
        at org.apache.lucene.tests.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:47)
        at org.junit.rules.RunRules.evaluate(RunRules.java:20)
        at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
        at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:368)
        at java.base/java.lang.Thread.run(Thread.java:833

kotwanikunal · 2022-04-06T17:53:49Z

start gradle check

opensearch-ci-bot · 2022-04-06T18:20:42Z

❌ Gradle Check failure fdbf247
Log 4254

Reports 4254

kotwanikunal · 2022-04-06T18:42:43Z

This seems to be affected by #2782

kotwanikunal · 2022-04-06T20:30:38Z

Will re run tests after #2795 gets merged in.

opensearch-ci-bot · 2022-04-06T22:12:18Z

✅ Gradle Check success 45b9f28
Log 4264

Reports 4264

tlfeng

Thank you! It's a great opportunity for me to understand the rolling upgrade test from your new codes. 👍👍

tlfeng · 2022-04-07T06:22:59Z

qa/rolling-upgrade/src/test/java/org/opensearch/upgrades/IndexingIT.java

+        switch (CLUSTER_TYPE) {
+            case OLD:
+                Version minNodeVersion = getMinNodeVersion();
+                if (minNodeVersion.before(Version.V_2_0_0)) {


When all the nodes in the cluster is in the same version, I think it's easier to directly use the variable UPGRADE_FROM_VERSION. (Please see the other test classes in the directory https://github.com/opensearch-project/OpenSearch/blob/1.3.1/qa/rolling-upgrade/src/test/java/org/opensearch/upgrades/JodaCompatibilityIT.java#L77 and https://github.com/opensearch-project/OpenSearch/blob/1.3.1/qa/rolling-upgrade/src/test/java/org/opensearch/upgrades/MappingIT.java#L45)

In addition, I think getting the minNodeVersion is originally designed to be used in a mixed-version cluster (case MIXED), when an API response from nodes of different versions are different. My conclusion is derived from the original test case testAutoIdWithOpTypeCreate() (https://github.com/opensearch-project/OpenSearch/blob/1.3.1/qa/rolling-upgrade/src/test/java/org/opensearch/upgrades/IndexingIT.java#L211-L213)

Further, learning from the above 2 tests classes, probably it will be more concise to use assumeTrue to filter the versions to run the test. 😁

assumeTrue("Mapping types is removed in 2.0", UPGRADE_FROM_VERSION.beforeVersion.V_2_0_0));

I was leaning on the minNodeVersion check to avoid any race/weird condition before I actually push in the typed indices. It does not seem to be an issue in my tests. Moved it to a regular check.

assertTrue will not work for all the cases since the bwcTest runs checks between not just current branch but a bunch of versions depending on compatibility. (

OpenSearch/qa/rolling-upgrade/build.gradle

Line 40 in 1b571ec

for (Version bwcVersion : BuildParams.bwcVersions.wireCompatible) {

) Backporting to older branches will break the assumption.

Ah, got your reason to use minNodeVersion check 😄 👍. The current code looks good, but I need some time to understand the limitation of assumeTrue you pointed out.

The meaning of assumeTrue("...", UPGRADE_FROM_VERSION.beforeVersion.V_2_0_0); is to filter the test to only run when upgrading from a cluster < 2.0 version.
I just learnt this from seeing the other test class, such as https://github.com/opensearch-project/OpenSearch/blob/1.3.1/qa/rolling-upgrade/src/test/java/org/opensearch/upgrades/JodaCompatibilityIT.java#L77

You could see the javadoc of assumeTrue() (https://javadoc.io/doc/com.carrotsearch.randomizedtesting/randomizedtesting-runner/2.7.1/com/carrotsearch/randomizedtesting/RandomizedTest.html#assumeTrue-java.lang.String-boolean-)

condition - If false an AssumptionViolatedException is thrown by this method and the test case (should be) ignored. Tests that are assumption-failures do not break builds.

Breaking the assumption is the result we want. 😄
So in my opinion, using assumeTrue() to filter the version to run the test can reduce your duplication usage of if (UPGRADE_FROM_VERSION.before(Version.V_2_0_0)) statement in every test case.

I misread it as assertTrue! This is a great find. Thanks for linking this 🙂
The if conditions currently do cover all of over scenarios, but will update with assumeTrue whenever I push any changes out for the test.

Sounds good! Yeah.. your PR does a good opportunity for me to find those interesting usages.

qa/rolling-upgrade/src/test/java/org/opensearch/upgrades/IndexingIT.java

opensearch-ci-bot · 2022-04-13T19:31:00Z

✅ Gradle Check success 19c281f
Log 4448

Reports 4448

Signed-off-by: Kunal Kotwani <[email protected]>

opensearch-ci-bot · 2022-04-13T22:54:38Z

✅ Gradle Check success d1caac9
Log 4453

Reports 4453

dreamer-89 · 2022-04-14T03:54:21Z

qa/rolling-upgrade/src/test/java/org/opensearch/upgrades/TypeRemovalIT.java

+
+        switch (CLUSTER_TYPE) {
+            case OLD:
+                if (UPGRADE_FROM_VERSION.before(Version.V_2_0_0)) {


What's the behavior of this test when ran against main running version 3.0 ?

Will this only create domain but wouldn't perform any assertions. If this understanding is correct, it will be NoOp on main (and all next versions). In that case, shall we have ToDo for removal Or do not merge into main (better) ?

I understand this is coming from writing feature specific bwc tests which gets added/removed in specific version.

Against 3.0, it will run against the previous wire compatible versions (v2.x.x). And yes, it will be a NoOp in the versions ahead.
Let me branch it off 2.0 instead.

Looks like we also need this test in 2.x branch? 😂

qa/rolling-upgrade/src/test/java/org/opensearch/upgrades/TypeRemovalIT.java

tlfeng · 2022-04-15T09:41:54Z

qa/rolling-upgrade/src/test/java/org/opensearch/upgrades/TypeRemovalIT.java

+        "^\\[types removal\\] (.+) include_type_name (.+) is deprecated\\. The parameter will be removed in the next major version\\.$"
+    );
+
+    private void useIgnoreTypesRemovalWarningsHandler(Request request) {


I'm curious is this new method having a same function with the existing method https://github.com/opensearch-project/OpenSearch/blob/1.3.1/test/framework/src/main/java/org/opensearch/test/rest/OpenSearchRestTestCase.java#L326 ?

kotwanikunal · 2022-04-15T15:45:29Z

Closing this in favor of #2901

Add indexing,search BwC tests for type mapping removal changes

0ce7789

Signed-off-by: Kunal Kotwani <[email protected]>

kotwanikunal requested a review from a team as a code owner March 25, 2022 19:00

kotwanikunal requested a review from dreamer-89 March 25, 2022 19:01

dreamer-89 requested changes Mar 25, 2022

View reviewed changes

qa/rolling-upgrade/src/test/java/org/opensearch/upgrades/IndexingIT.java Outdated Show resolved Hide resolved

dreamer-89 requested review from andrross and nknize March 25, 2022 19:50

Add warning and failure checks for _doc mapping bwc tests

92bc227

Signed-off-by: Kunal Kotwani <[email protected]>

kotwanikunal force-pushed the bwc-tests-type-mapping branch from f53b5cd to 92bc227 Compare March 28, 2022 20:44

kotwanikunal added 2 commits March 30, 2022 10:28

Add reindexing, template BwC tests for type removal

93a7cdb

Signed-off-by: Kunal Kotwani <[email protected]>

Merge branch 'opensearch-project:main' into bwc-tests-type-mapping

6a15e42

kotwanikunal force-pushed the bwc-tests-type-mapping branch from 88d92c8 to 90a3fdd Compare March 30, 2022 19:08

kotwanikunal force-pushed the bwc-tests-type-mapping branch from 3ccfc04 to 7aec869 Compare April 6, 2022 04:03

kotwanikunal removed the WIP Work in progress label Apr 6, 2022

Add a new repo location for test runs

fdbf247

Signed-off-by: Kunal Kotwani <[email protected]>

kotwanikunal force-pushed the bwc-tests-type-mapping branch from 7aec869 to fdbf247 Compare April 6, 2022 17:11

Merge branch 'opensearch-project:main' into bwc-tests-type-mapping

45b9f28

tlfeng reviewed Apr 7, 2022

View reviewed changes

tlfeng added :test Adding or fixing a test v2.0.0 Version 2.0.0 v3.0.0 Issues and PRs related to version 3.0.0 backport 2.x Backport to 2.x branch backport 2.0 Backport to 2.0 branch labels Apr 7, 2022

Merge branch 'opensearch-project:main' into bwc-tests-type-mapping

19c281f

Add a separate type removal test class

d1caac9

Signed-off-by: Kunal Kotwani <[email protected]>

tlfeng approved these changes Apr 14, 2022

View reviewed changes

dreamer-89 reviewed Apr 14, 2022

View reviewed changes

kotwanikunal mentioned this pull request Apr 14, 2022

Add type mapping removal bwc tests for indexing, searching, snapshots #2901

Merged

5 tasks

tlfeng reviewed Apr 15, 2022

View reviewed changes

kotwanikunal closed this Apr 15, 2022

kotwanikunal deleted the bwc-tests-type-mapping branch May 16, 2022 18:59

Add indexing,search BwC tests for type mapping removal changes #2601

Add indexing,search BwC tests for type mapping removal changes #2601

Conversation

kotwanikunal commented Mar 25, 2022

Description

Issues Resolved

Check List

opensearch-ci-bot commented Mar 25, 2022

opensearch-ci-bot commented Mar 28, 2022

dreamer-89 commented Mar 28, 2022 • edited Loading

kotwanikunal commented Mar 28, 2022

opensearch-ci-bot commented Mar 28, 2022

dreamer-89 commented Mar 28, 2022

dreamer-89 commented Mar 28, 2022

dreamer-89 commented Mar 28, 2022

opensearch-ci-bot commented Mar 28, 2022

kotwanikunal commented Mar 28, 2022

kotwanikunal commented Mar 28, 2022

dreamer-89 commented Mar 28, 2022

opensearch-ci-bot commented Mar 28, 2022

opensearch-ci-bot commented Mar 30, 2022

opensearch-ci-bot commented Mar 30, 2022

kotwanikunal commented Mar 30, 2022

opensearch-ci-bot commented Mar 30, 2022

opensearch-ci-bot commented Mar 30, 2022

dreamer-89 commented Mar 31, 2022

opensearch-ci-bot commented Apr 6, 2022

opensearch-ci-bot commented Apr 6, 2022

kotwanikunal commented Apr 6, 2022

kotwanikunal commented Apr 6, 2022

opensearch-ci-bot commented Apr 6, 2022

kotwanikunal commented Apr 6, 2022

kotwanikunal commented Apr 6, 2022

opensearch-ci-bot commented Apr 6, 2022

tlfeng left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tlfeng Apr 14, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

opensearch-ci-bot commented Apr 13, 2022

opensearch-ci-bot commented Apr 13, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kotwanikunal commented Apr 15, 2022

dreamer-89 commented Mar 28, 2022 •

edited

Loading

tlfeng Apr 14, 2022 •

edited

Loading