Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type mapping removal bwc tests for indexing, searching, snapshots #2901

Merged

Conversation

kotwanikunal
Copy link
Member

@kotwanikunal kotwanikunal commented Apr 14, 2022

Signed-off-by: Kunal Kotwani [email protected]

Description

  • Add backwards compatibility tests for testing type mapping changes from OS2.0

Issues Resolved

Check List

  • New functionality includes testing.
  • All tests pass
  • New functionality has been documented.
  • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 7e82cce5c1dda50d428265011d2a6806cb08dbe1
Log 4485

Reports 4485

@kotwanikunal
Copy link
Member Author

kotwanikunal commented Apr 14, 2022

Looking into the failure.

@kotwanikunal kotwanikunal force-pushed the bwc-test-type-mapping branch from 7e82cce to 9caac64 Compare April 15, 2022 06:17
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 9caac64c0841d54672cbea03f1526d685254fdc2
Log 4505

Reports 4505

Copy link
Collaborator

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments.. otherwise LGTM! Thx for doing this.

Copy link
Member

@dreamer-89 dreamer-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

@kotwanikunal kotwanikunal force-pushed the bwc-test-type-mapping branch from 9caac64 to 702a8e1 Compare April 15, 2022 18:00
@kotwanikunal kotwanikunal added the backport 2.x Backport to 2.x branch label Apr 15, 2022
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 702a8e121f3286a1549f991eee62f61cc2c645ae
Log 4517

Reports 4517

@kotwanikunal kotwanikunal force-pushed the bwc-test-type-mapping branch from 702a8e1 to 6bc1501 Compare April 15, 2022 18:09
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 6bc1501afe84353c934643143a5dfa29fadb09e3
Log 4518

Reports 4518

@kotwanikunal kotwanikunal force-pushed the bwc-test-type-mapping branch from 6bc1501 to 04cbee2 Compare April 15, 2022 18:26
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 04cbee2
Log 4519

Reports 4519

@kotwanikunal kotwanikunal merged commit 4372892 into opensearch-project:2.0 Apr 15, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 15, 2022
kotwanikunal added a commit that referenced this pull request Apr 16, 2022
…hing, snapshots (#2921)

* Add type mapping removal bwc tests for indexing, searching, snapshots (#2901)

Signed-off-by: Kunal Kotwani <[email protected]>
(cherry picked from commit 4372892)

* Update version for 2.x branch

Signed-off-by: Kunal Kotwani <[email protected]>

* Limiting rolling upgrade checks to test upgrades from <v2.0.0

Signed-off-by: Kunal Kotwani <[email protected]>

Co-authored-by: Kunal Kotwani <[email protected]>
@kotwanikunal kotwanikunal deleted the bwc-test-type-mapping branch May 16, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants