-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type mapping removal bwc tests for indexing, searching, snapshots #2901
Add type mapping removal bwc tests for indexing, searching, snapshots #2901
Conversation
❌ Gradle Check failure 7e82cce5c1dda50d428265011d2a6806cb08dbe1 |
Looking into the failure. |
7e82cce
to
9caac64
Compare
test/framework/src/main/java/org/opensearch/test/rest/OpenSearchRestTestCase.java
Outdated
Show resolved
Hide resolved
✅ Gradle Check success 9caac64c0841d54672cbea03f1526d685254fdc2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small comments.. otherwise LGTM! Thx for doing this.
test/framework/src/main/java/org/opensearch/test/rest/OpenSearchRestTestCase.java
Outdated
Show resolved
Hide resolved
qa/rolling-upgrade/src/test/java/org/opensearch/upgrades/MappingTypeRemovalIT.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM!
qa/rolling-upgrade/src/test/java/org/opensearch/upgrades/MappingTypeRemovalIT.java
Show resolved
Hide resolved
9caac64
to
702a8e1
Compare
❌ Gradle Check failure 702a8e121f3286a1549f991eee62f61cc2c645ae |
702a8e1
to
6bc1501
Compare
❌ Gradle Check failure 6bc1501afe84353c934643143a5dfa29fadb09e3 |
Signed-off-by: Kunal Kotwani <[email protected]>
6bc1501
to
04cbee2
Compare
…#2901) Signed-off-by: Kunal Kotwani <[email protected]> (cherry picked from commit 4372892)
…hing, snapshots (#2921) * Add type mapping removal bwc tests for indexing, searching, snapshots (#2901) Signed-off-by: Kunal Kotwani <[email protected]> (cherry picked from commit 4372892) * Update version for 2.x branch Signed-off-by: Kunal Kotwani <[email protected]> * Limiting rolling upgrade checks to test upgrades from <v2.0.0 Signed-off-by: Kunal Kotwani <[email protected]> Co-authored-by: Kunal Kotwani <[email protected]>
Signed-off-by: Kunal Kotwani [email protected]
Description
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.