Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block unsafe bootstrap when remote state is enabled #9965

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

soosinha
Copy link
Member

Description

During unsafe bootstrap, node will form a cluster with a new cluster UUID but with the existing metadata. This new state will not know about the previous cluster UUIDs and so we will not able to construct the cluster UUID chain to get the last known cluster UUID to restore from. So we need to block unsafe-bootstrap when remote cluster state is enabled.

Related Issues

#9926

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2023

Compatibility status:

Checks if related components are compatible with change a9c5dff

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.repositories.azure.AzureBlobContainerRetriesTests.testReadNonexistentBlobThrowsNoSuchFileException

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #9965 (a9c5dff) into main (c100c0c) will decrease coverage by 0.05%.
Report is 6 commits behind head on main.
The diff coverage is 42.85%.

@@             Coverage Diff              @@
##               main    #9965      +/-   ##
============================================
- Coverage     71.16%   71.11%   -0.05%     
- Complexity    58114    58137      +23     
============================================
  Files          4824     4824              
  Lines        273897   273901       +4     
  Branches      39910    39911       +1     
============================================
- Hits         194926   194793     -133     
- Misses        62573    62818     +245     
+ Partials      16398    16290     -108     
Files Changed Coverage Δ
...main/java/org/opensearch/common/collect/Tuple.java 64.70% <ø> (ø)
...java/org/opensearch/common/crypto/DataKeyPair.java 0.00% <ø> (ø)
...h/common/crypto/DecryptedRangedStreamProvider.java 0.00% <ø> (ø)
...g/opensearch/compress/spi/CompressionProvider.java 100.00% <ø> (ø)
...dination/UnsafeBootstrapClusterManagerCommand.java 0.00% <0.00%> (ø)
...cli/src/main/java/org/opensearch/cli/Terminal.java 74.73% <100.00%> (ø)

... and 465 files with indirect coverage changes

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@shwetathareja shwetathareja merged commit 18ac060 into opensearch-project:main Sep 12, 2023
@shwetathareja shwetathareja added the backport 2.x Backport to 2.x branch label Sep 12, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 12, 2023
Signed-off-by: Sooraj Sinha <[email protected]>
(cherry picked from commit 18ac060)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
shwetathareja pushed a commit that referenced this pull request Sep 12, 2023
(cherry picked from commit 18ac060)

Signed-off-by: Sooraj Sinha <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@shwetathareja shwetathareja added the backport 2.10 Backport to 2.10 branch label Sep 12, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 12, 2023
Signed-off-by: Sooraj Sinha <[email protected]>
(cherry picked from commit 18ac060)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
shwetathareja pushed a commit that referenced this pull request Sep 12, 2023
(cherry picked from commit 18ac060)

Signed-off-by: Sooraj Sinha <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
sarthakaggarwal97 pushed a commit to sarthakaggarwal97/OpenSearch that referenced this pull request Sep 20, 2023
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
vikasvb90 pushed a commit to vikasvb90/OpenSearch that referenced this pull request Oct 10, 2023
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
@soosinha soosinha deleted the unsafe_bootstrap branch December 20, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport 2.10 Backport to 2.10 branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants