-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block unsafe bootstrap when remote state is enabled #9965
Block unsafe bootstrap when remote state is enabled #9965
Conversation
.../src/main/java/org/opensearch/cluster/coordination/UnsafeBootstrapClusterManagerCommand.java
Outdated
Show resolved
Hide resolved
Gradle Check (Jenkins) Run Completed with:
|
Compatibility status:Checks if related components are compatible with change a9c5dff Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git] |
2056474
to
1f5d1cf
Compare
Gradle Check (Jenkins) Run Completed with:
|
1f5d1cf
to
f723b9a
Compare
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #9965 +/- ##
============================================
- Coverage 71.16% 71.11% -0.05%
- Complexity 58114 58137 +23
============================================
Files 4824 4824
Lines 273897 273901 +4
Branches 39910 39911 +1
============================================
- Hits 194926 194793 -133
- Misses 62573 62818 +245
+ Partials 16398 16290 -108
|
.../src/main/java/org/opensearch/cluster/coordination/UnsafeBootstrapClusterManagerCommand.java
Show resolved
Hide resolved
.../src/main/java/org/opensearch/cluster/coordination/UnsafeBootstrapClusterManagerCommand.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sooraj Sinha <[email protected]>
f723b9a
to
a9c5dff
Compare
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Sooraj Sinha <[email protected]> (cherry picked from commit 18ac060) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 18ac060) Signed-off-by: Sooraj Sinha <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Sooraj Sinha <[email protected]> (cherry picked from commit 18ac060) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 18ac060) Signed-off-by: Sooraj Sinha <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ct#9965) Signed-off-by: Sooraj Sinha <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]>
…ct#9965) Signed-off-by: Sooraj Sinha <[email protected]>
…ct#9965) Signed-off-by: Sooraj Sinha <[email protected]> Signed-off-by: Ivan Brusic <[email protected]>
…ct#9965) Signed-off-by: Sooraj Sinha <[email protected]>
…ct#9965) Signed-off-by: Sooraj Sinha <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
During unsafe bootstrap, node will form a cluster with a new cluster UUID but with the existing metadata. This new state will not know about the previous cluster UUIDs and so we will not able to construct the cluster UUID chain to get the last known cluster UUID to restore from. So we need to block unsafe-bootstrap when remote cluster state is enabled.
Related Issues
#9926
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.