Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump to 1.4.0 #256

Closed
wants to merge 1 commit into from
Closed

Conversation

ylwu-amzn
Copy link
Collaborator

Signed-off-by: Yaliang Wu [email protected]

Description

bump to 1.4.0

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Yaliang Wu <[email protected]>
@ylwu-amzn ylwu-amzn requested a review from a team March 28, 2022 19:02
@ylwu-amzn
Copy link
Collaborator Author

CI failed

Could not find org.opensearch:common-utils:1.4.0.0-SNAPSHOT.

@amitgalitz
Copy link
Member

CI failed

Could not find org.opensearch:common-utils:1.4.0.0-SNAPSHOT.

latest common-utils 1.x commit is version bumped to 1.4, not sure why that is not being made.
opensearch-project/common-utils@b557220

@ohltyler
Copy link
Member

CI failed

Could not find org.opensearch:common-utils:1.4.0.0-SNAPSHOT.

latest common-utils 1.x commit is version bumped to 1.4, not sure why that is not being made. opensearch-project/common-utils@b557220

I added as part of the manifest in this PR, so not sure. Any idea on next steps / why it wasn't uploaded? @peternied

@peternied
Copy link
Member

@ohltyler I did a quick look, it seems like 1.4.0's build is failing so these artifacts aren't being published for consumption @opensearch-project/engineering-effectiveness is there someone looking into that?

@CEHENKLE
Copy link
Member

Hey folks -- there is no 1.4 release.

We discussed it at the community meeting, followed up in the forums https://discuss.opendistrocommunity.dev/t/2-0-release-date-discussion/8901 for feedback. Then updated the website https://opensearch.org/blog/partners/2022/02/roadmap-proposal/ and then our public roadmap: https://github.com/orgs/opensearch-project/projects/1

Thanks,
/C

@ohltyler
Copy link
Member

ohltyler commented Mar 28, 2022

Hey folks -- there is no 1.4 release.

We discussed it at the community meeting, followed up in the forums https://discuss.opendistrocommunity.dev/t/2-0-release-date-discussion/8901 for feedback. Then updated the website https://opensearch.org/blog/partners/2022/02/roadmap-proposal/ and then our public roadmap: https://github.com/orgs/opensearch-project/projects/1

Thanks, /C

Understood, the purpose for doing this is because core OpenSearch and Dashboards had bumped 1.x branches to 1.4.0 (which makes sense), but then causes all component CIs on 1.x branches to fail due to version mismatch. So we are trying to bump components to 1.4.0.0 to maintain passing CI on all of the repo branches, and for being prepared for a possible 1.4 release in the future. Ref: opensearch-project/opensearch-build#1825 (comment)

@peternied
Copy link
Member

Hey folks -- there is no 1.4 release.

We discussed it at the community meeting, followed up in the forums https://discuss.opendistrocommunity.dev/t/2-0-release-date-discussion/8901 for feedback. Then updated the website https://opensearch.org/blog/partners/2022/02/roadmap-proposal/ and then our public roadmap: https://github.com/orgs/opensearch-project/projects/1

Thanks, /C

@CEHENKLE Could we update the 1.4.0 release issue with these details? opensearch-project/opensearch-build#1749 This has been the typical way that our developers have been getting notified about new releases, or in this case I'd recommend using this same channel for no release.

@CEHENKLE
Copy link
Member

@peternied Good call out. Done.

@ylwu-amzn
Copy link
Collaborator Author

ylwu-amzn commented Mar 29, 2022

Understood, the purpose for doing this is because core OpenSearch and Dashboards had bumped 1.x branches to 1.4.0 (which makes sense), but then causes all component CIs on 1.x branches to fail due to version mismatch. So we are trying to bump components to 1.4.0.0 to maintain passing CI on all of the repo branches, and for being prepared for a possible 1.4 release in the future. Ref: opensearch-project/opensearch-build#1825 (comment)

Agree with Tyler @ohltyler , OpenSearch core has bumped to 1.4 opensearch-project/OpenSearch#2423, we should also follow the version. Will keep this PR open until commons-util 1.4 ready.

@peternied
Copy link
Member

@ylwu-amzn @ohltyler Since version 1.4.0 will never be released, time spend on it won't be useful. Do we have project process that are broken that need to handle this case?

@ohltyler
Copy link
Member

@ylwu-amzn @ohltyler Since version 1.4.0 will never be released, time spend on it won't be useful. Do we have project process that are broken that need to handle this case?

I think the idea is that ideally a 1.x or 2.x branch's CI remains passing, as that usually represents the next version to be released, and can help catch errors fast. Because core and common-utils/job-scheduler usually version bump immediately following a release, I think the only gap is having auto-version-increment jobs set up for all components similar to job-scheduler / common-utils.

@peternied
Copy link
Member

@ohltyler what do you think about us instead rolling back job-scheduler and common-utils? Seems like that is the root cause of this bad state

@ohltyler
Copy link
Member

@ohltyler what do you think about us instead rolling back job-scheduler and common-utils? Seems like that is the root cause of this bad state

I worked on bumping those because of core OpenSearch/Dashboards had bumped to 1.4.0. I believe they should be bumped to follow the current versioning strategy (1.x bumps minor version, 1.3.0 bumps to 1.3.1, etc.), such that after a release, everything is bumped to track a new version in case of a future release at such version.

@ylwu-amzn
Copy link
Collaborator Author

Close this PR as we don't have clear decision yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants