Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Correct NeuralQueryBuilder doEquals() and doHashCode(). #1090

Merged

Conversation

bzhangam
Copy link
Contributor

Signed-off-by: Bo Zhang [email protected]
(cherry picked from commit ec6b30d)

Description

Backport #1045 to 2.x

Related Issues

N/A

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@bzhangam bzhangam changed the title [Backport 2.x] Correct NeuralQueryBuilder doEquals() and doHashCode(). (#1045) [Backport 2.x] Correct NeuralQueryBuilder doEquals() and doHashCode(). Jan 13, 2025
@bzhangam bzhangam closed this Jan 13, 2025
@bzhangam bzhangam reopened this Jan 13, 2025
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 88.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.22%. Comparing base (19ea370) to head (9c7d28a).
Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
...nsearch/neuralsearch/query/NeuralQueryBuilder.java 86.95% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x    #1090      +/-   ##
============================================
+ Coverage     80.18%   80.22%   +0.04%     
- Complexity     1138     1141       +3     
============================================
  Files            87       87              
  Lines          3941     3960      +19     
  Branches        664      668       +4     
============================================
+ Hits           3160     3177      +17     
+ Misses          532      531       -1     
- Partials        249      252       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martin-gaievski martin-gaievski merged commit a349cf8 into opensearch-project:2.x Jan 13, 2025
116 of 122 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants