Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: OpenSearch build builds OpenSearch Dashboards #1634

Closed
dblock opened this issue Feb 17, 2022 · 2 comments · Fixed by #1646
Closed

[Bug]: OpenSearch build builds OpenSearch Dashboards #1634

dblock opened this issue Feb 17, 2022 · 2 comments · Fixed by #1646
Assignees
@kavilla
Labels
bug Something isn't working

Comments

@dblock
Copy link
Member

dblock commented Feb 17, 2022 •
edited
Loading

Describe the bug

In #590 we have introduced a -d option that says "build OpenSearch Dashboards". This is odd, why would OpenSearch build know anything about OpenSearch Dashboards?

To reproduce

See https://github.com/opensearch-project/opensearch-build/pull/1631/files#r808574435

Expected behavior

Change the default script, remove -d from OpenSearch build scripts.

Screenshots

If applicable, add screenshots to help explain your problem.

Host / Environment

No response

Additional context

No response

Relevant log output

No response
@dblock dblock added bug Something isn't working untriaged Issues that have not yet been triaged labels Feb 17, 2022
@dblock
Copy link
Member Author

dblock commented Feb 17, 2022

@kavilla Could you please give some context here? Thanks!

@dblock dblock mentioned this issue Feb 17, 2022
Merged
1 task
@kavilla
Copy link
Member

kavilla commented Feb 17, 2022

@kavilla Could you please give some context here? Thanks!

Yeah it should be removed. It was added in the default script when the default script was just the one [REF].

kavilla added a commit to kavilla/opensearch-build that referenced this issue Feb 17, 2022
@kavilla
[Cleanup] Remove DASHBOARD from default OpenSearch script
52e86ff 
This was added here:
https://github.com/opensearch-project/opensearch-build/pull/590/files

When the default script was shared. This removes this unused legacy
code.

Issue:
opensearch-project#1634

Signed-off-by: Kawika Avilla <[email protected]>
@kavilla kavilla mentioned this issue Feb 17, 2022
Merged
1 task
@kavilla kavilla linked a pull request Feb 17, 2022 that will close this issue
[Cleanup] Remove DASHBOARD from default OpenSearch script #1646
Merged
1 task
@zelinh zelinh removed the untriaged Issues that have not yet been triaged label Feb 17, 2022
dblock pushed a commit that referenced this issue Feb 17, 2022
@kavilla
[Cleanup] Remove DASHBOARD from default OpenSearch script (#1646)
056de8a 
This was added here:
https://github.com/opensearch-project/opensearch-build/pull/590/files

When the default script was shared. This removes this unused legacy
code.

Issue:
#1634

Signed-off-by: Kawika Avilla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kavilla kavilla

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Cleanup] Remove DASHBOARD from default OpenSearch script kavilla/opensearch-build
3 participants
@dblock @kavilla @zelinh