[Build] bundle OpenSearch Dashboards #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavilla
force-pushed
the
avillk/osd_build_plugins_in_default
branch
from
7b2665c to
b5f3140
Compare
|
Previous PR: #435 |
kavilla
force-pushed
the
avillk/osd_build_plugins_in_default
branch
3 times, most recently
from
508c001 to
466268d
Compare
Produce an OpenSearch Dashboards bundle with plugins provided by a manifest. This requires the manifest to be in order with plugins first and then Dashboards being last. The plugins will need to pulled down and placed in the plugins folder. Then we need to bootstrap to generate the modules so that we can actually install the plugins to the release build. What is missing or not verified * Environment setup, this requires nvm and yarn to be already set up. We will need to set that up. * Dropping the custom config into the bundle * Signing of the artifact * Tests Related Issue: opensearch-project#158 Signed-off-by: Kawika Avilla <[email protected]>
kavilla
force-pushed
the
avillk/osd_build_plugins_in_default
branch
from
466268d to
4acf66c
Compare
Codecov Report
@@ Coverage Diff @@
## main #590 +/- ##
==========================================
- Coverage 82.65% 82.46% -0.19%
==========================================
Files 61 61
Lines 1660 1671 +11
==========================================
+ Hits 1372 1378 +6
- Misses 288 293 +5
Continue to review full report at Codecov.
|
dblock
approved these changes
Sep 24, 2021
|
Good. I can take the refactoring of the dashboards |
saratvemulapalli
approved these changes
Sep 24, 2021
Comment on lines
+68
to
+88
| mkdir -p $OUTPUT/plugins | ||
| PLUGIN_NAME=$(basename "$PWD") | ||
| # TODO: [CLEANUP] Needed OpenSearch Dashboards git repo to build the required modules for plugins | ||
| # This makes it so there is a dependency on having Dashboards pulled already. | ||
| cp -r ../$PLUGIN_NAME/ ../OpenSearch-Dashboards/plugins | ||
| echo "BUILD MODULES FOR $PLUGIN_NAME" | ||
| (cd ../OpenSearch-Dashboards && yarn osd bootstrap) | ||
| echo "BUILD RELEASE ZIP FOR $PLUGIN_NAME" | ||
| (cd ../OpenSearch-Dashboards/plugins/$PLUGIN_NAME && yarn plugin-helpers build) | ||
| echo "COPY $PLUGIN_NAME.zip" | ||
| cp -r ../OpenSearch-Dashboards/plugins/$PLUGIN_NAME/build/$PLUGIN_NAME-$VERSION.zip $OUTPUT/plugins/ | ||
| else | ||
| ./gradlew assemble --no-daemon --refresh-dependencies -DskipTests=true -Dopensearch.version=$VERSION -Dbuild.snapshot=$SNAPSHOT | ||
|
|
||
| zipPath=$(find . -path \*build/distributions/*.zip) | ||
| distributions="$(dirname "${zipPath}")" | ||
|
|
||
| echo "COPY ${distributions}/*.zip" | ||
| mkdir -p $OUTPUT/plugins | ||
| cp ${distributions}/*.zip ./$OUTPUT/plugins | ||
| fi |
There was a problem hiding this comment.
We should test these scripts as part of our CI workflows.
A follow up for both OpenSearch and Dashboards.
There was a problem hiding this comment.
Opened up an issue: #591
This was referenced Sep 24, 2021
19 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Produce an OpenSearch Dashboards bundle with plugins provided by a manifest.
This requires the manifest to be in order with plugins first and then Dashboards
being last. The plugins will need to pulled down and placed in the plugins
folder. Then we need to bootstrap to generate the modules so that we can actually
install the plugins to the release build.
What is missing or not verified
We will need to set that up.
Signed-off-by: Kawika Avilla [email protected]
Issues Resolved
Partial #158
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.