Fix: broken links and typos #4117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sachin Sahu <[email protected]>
SachinSahu431
requested review from
dblock,
peterzhuamazon,
bbarani,
gaiksaya,
rishabh6788,
zelinh,
jordarlu,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
gaiksaya
requested changes
Oct 10, 2023
Codecov Report
@@ Coverage Diff @@
## main #4117 +/- ##
==========================================
- Coverage 93.27% 92.99% -0.28%
==========================================
Files 187 187
Lines 5753 5753
==========================================
- Hits 5366 5350 -16
- Misses 387 403 +16 |
Signed-off-by: Rishabh Singh <[email protected]> Signed-off-by: Sachin Sahu <[email protected]>
Signed-off-by: Sayali Gaikawad <[email protected]> Signed-off-by: Sachin Sahu <[email protected]>
Signed-off-by: Rishabh Singh <[email protected]> Signed-off-by: Sachin Sahu <[email protected]>
Signed-off-by: Rishabh Singh <[email protected]> Signed-off-by: Sachin Sahu <[email protected]>
Signed-off-by: Sachin Sahu <[email protected]> Signed-off-by: Sachin Sahu <[email protected]>
|
Hi @SachinSahu431 I am merging this for now. You can try rebasing the git commits squash to 1 from next time. Makes it cleaner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix broken links and typographical errors in the existing readme files.
For example this section refers to opensearch-2.8.0-test.yml file, which is no longer available on main branch, and has been moved to opensearch-2.8.0 branch.
There are also some other changes such as removing clearly noticeable typos, unclosed brackets, adding missing link to Slack public release channel, etc.
Issues Resolved
None
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.