[Build] bundle OpenSearch Dashboards #435
Conversation
| yarn osd bootstrap | ||
|
|
||
| echo "Building artifact" | ||
| yarn build --skip-os-packages --release |
There was a problem hiding this comment.
We are working on actually working on de-coupling things here: opensearch-project/OpenSearch-Dashboards#473
For now this will build all the non-OS Packages artifacts and then it will just grab the one it needs.
Codecov Report
@@ Coverage Diff @@
## main #435 +/- ##
=======================================
Coverage ? 69.31%
=======================================
Files ? 58
Lines ? 1509
Branches ? 0
=======================================
Hits ? 1046
Misses ? 463
Partials ? 0 Continue to review full report at Codecov.
|
| ./"${OUTPUT}"/bundle/opensearch-dashboards/bin/opensearch-dashboards-plugin --allow-root install file:./plugins/$PLUGIN_NAME/build/$PLUGIN_NAME-$VERSION.zip | ||
| done | ||
|
|
||
|
|
There was a problem hiding this comment.
TODO: recreate the bundled tarball.
| # - name: ganttChartDashboards | ||
| # repository: ???????? | ||
| # ref: main | ||
| - name: OpenSearch-Dashboards |
There was a problem hiding this comment.
It shouldn't be last if each component only builds as part of build, and is installed as part of assemble.
bundle-workflow/scripts/components/OpenSearch-Dashboards/build.sh
Outdated
Show resolved
Hide resolved
|
|
||
| mkdir -p "${OUTPUT}/bundle/opensearch-dashboards" | ||
|
|
||
| # Untar for the plugins |
There was a problem hiding this comment.
You should not be installing plugins here, but let the assemble step take care of it one plugin at a time.
There was a problem hiding this comment.
Hi @kavilla thanks for the initial scripts.
Please also check our old script for reference, you missed some steps such as adding the tweaked dashboards yml file, etc.
| mkdir -p "${OUTPUT}/bundle" | ||
| mkdir -p "${OUTPUT}/plugins" | ||
|
|
||
| # Release gets built to /target, regular non-tarball gets built to /build |
There was a problem hiding this comment.
This needs to be moved out into the assemble step.
Produce an OpenSearch Dashboards bundle with plugins provided by a manifest. This requires the manifest to be in order with plugins first and then Dashboards being last. The plugins will need to pulled down and placed in the plugins folder. Then we need to bootstrap to generate the modules so that we can actually install the plugins to the release build. What is missing? * Environment setup, this requires nvm and yarn to be already set up. We will need to set that up. * Signing of the artifact * Diff between release and snapshot Related Issue: opensearch-project#158 Signed-off-by: Kawika Avilla <[email protected]>
There was conditional being checked if the plugin had the x.x.x.x versioning while yarn plugin builder outputs regular semvar. Modified the conditional to get building. Moved the manifests to the correct location and updated to strings. Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
| @@ -48,6 +48,21 @@ $ pipenv --version | |||
| pipenv, version 19.0 | |||
| ``` | |||
|
|
|||
| #### Install NVM and Node | |||
Description
Produce an OpenSearch Dashboards bundle with plugins provided by a manifest.
This requires the manifest to be in order with plugins first and then Dashboards
being last. The plugins will need to pulled down and placed in the plugins
folder. Then we need to bootstrap to generate the modules so that we can actually
install the plugins to the release build.
What is missing?
We will need to set that up.
look like.
Signed-off-by: Kawika Avilla [email protected]
Issues Resolved
#158
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.