MON-1116: Bump to f55d854c #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gökhan Kocak <[email protected]> Co-authored-by: Gökhan Kocak <[email protected]>
* Added a placeholder for devdocs Signed-off-by: Yash <[email protected]> * some nitpickings Signed-off-by: Yash <[email protected]>
Signed-off-by: Ganesh Vernekar <[email protected]>
* Added Series request hints support to BucketStore Signed-off-by: Marco Pracucci <[email protected]> * Refactoring based on feedback received Signed-off-by: Marco Pracucci <[email protected]> * Renamed var Signed-off-by: Marco Pracucci <[email protected]> * Improved tests Signed-off-by: Marco Pracucci <[email protected]> * Refactoring based on feedback received Signed-off-by: Marco Pracucci <[email protected]>
* Improve binary index-header documentation Signed-off-by: Marco Pracucci <[email protected]> * Improved binary index-header doc based on feedback Signed-off-by: Marco Pracucci <[email protected]>
* ui: Fix UI state being shared Signed-off-by: Prem Kumar <[email protected]> * format bindata.go Signed-off-by: Prem Kumar <[email protected]>
…rting for StoreAPI + Optimized iter chunk dedup. (thanos-io#2710) * Deduplicate chunk dups on proxy StoreAPI level. Recommend chunk sorting for StoreAPI. Also: Merge same series together on proxy level instead select. This allows better dedup efficiency. Partially fixes: thanos-io#2303 Cases like overlapped data from store and sidecar and 1:1 duplicates are optimized as soon as it's possible. This case was highly visible on GitLab repro data and exists in most of Thanos setup. Signed-off-by: Bartlomiej Plotka <[email protected]> * Optimized algorithm to combine series only on start. Signed-off-by: Bartlomiej Plotka <[email protected]> * Optimized chunk comparision for overlaps. Signed-off-by: Bartlomiej Plotka <[email protected]> * Optimized deduplication for deduplicated chunk on query level as well. Never use proto .String() in fast path! Signed-off-by: Bartlomiej Plotka <[email protected]>
+ some nits from Bartek Signed-off-by: Sergiusz Urbaniak <[email protected]>
openshift-ci-robot
added
the
approved
|
think it needs a revendor? Otherwise yay!! 🎉 |
|
You need to update the |
|
@lilic @simonpasquier indeed, i forgot about that one, ptal 👍 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lilic, s-urbaniak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-aws |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now also pulls in deduplication logic for Rules API
/cc @openshift/openshift-team-monitoring