Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to v0.30.0-rc.0 #97

Closed
wants to merge 85 commits into from
Closed

Update to v0.30.0-rc.0 #97

wants to merge 85 commits into from

Conversation

JoaoBraveCoding
Copy link

Changes

The bot failed to do this merge automatically because https://github.com/openshift/thanos/blob/master/cmd/thanos/config.go#L199-L203 I've already opened a PR to fix this thanos-io#5997 so in the next Thanos tag the bot will probably fail and we should then be able to remove this code.

PS: this is an update to an rc tag because it was marked as latest when it was released https://github.com/thanos-io/thanos/releases/tag/v0.30.0-rc.0 we can also simply skip it and wait for the next tag.

cc @jan--f @simonpasquier

Verification

GiedriusS and others added 30 commits October 21, 2022 17:56
* *: cut 0.29.0-rc.0 (thanos-io#5806)

* *: cut 0.29.0-rc.0

This looks like one of the bigger releases. I suggest releasing this now
to make it smaller even though we have some exciting things in the
pipeline.

Signed-off-by: Giedrius Statkevičius <[email protected]>

* CHANGELOG: make changes according to suggestions

Signed-off-by: Giedrius Statkevičius <[email protected]>

Signed-off-by: Giedrius Statkevičius <[email protected]>

* CHANGELOG: mark 0.29.0 as in progress

Signed-off-by: Giedrius Statkevičius <[email protected]>

Signed-off-by: Giedrius Statkevičius <[email protected]>
Add a metric that shows the distribution of how many postings (in bytes)
were needed for each Series() call. Useful for determining limits.

Signed-off-by: Giedrius Statkevičius <[email protected]>

Signed-off-by: Giedrius Statkevičius <[email protected]>
…-io#5703)

* Adding hashes to raw chunks and populating it from bucket store

Signed-off-by: Pedro Tanaka <[email protected]>

* Adding flag on SeriesRequest to control whether to calculate or not hashes

Signed-off-by: Pedro Tanaka <[email protected]>

* Only calculate hash on series request for bucket when needed

Signed-off-by: Pedro Tanaka <[email protected]>

* implement e2e test for prometheus store

Signed-off-by: Pedro Tanaka <[email protected]>

fixing flaky e2e tests

Signed-off-by: Pedro Tanaka <[email protected]>

fix integration test for prometheus

Signed-off-by: Pedro Tanaka <[email protected]>

* calculating hash on TSDB Series() request as well

Signed-off-by: Pedro Tanaka <[email protected]>

Final fix on error linting

Signed-off-by: Pedro Tanaka <[email protected]>

* Using sync.Pool to avoid gc pressure

Signed-off-by: Pedro Tanaka <[email protected]>

* Fixing whitespace

Signed-off-by: Pedro Tanaka <[email protected]>

* Fixing nit on proto

Signed-off-by: Pedro Tanaka <[email protected]>

* Fixing hashpool

Signed-off-by: Pedro Tanaka <[email protected]>

* Using pool from callee instead of inside helper function

Signed-off-by: Pedro Tanaka <[email protected]>

* Reusing the hasher pool in other places

Signed-off-by: Pedro Tanaka <[email protected]>

* Calculating hashes by default

Signed-off-by: Pedro Tanaka <[email protected]>

* Adjusting e2e and integration tests

Signed-off-by: Pedro Tanaka <[email protected]>

* fixing linting and e2e test

Signed-off-by: Pedro Tanaka <[email protected]>

* Fixing new call format for tsdb.NewHead

Signed-off-by: Pedro Tanaka <[email protected]>

* Adding option to control whether to hash chunks on stores or not

Signed-off-by: Pedro Tanaka <[email protected]>

Signed-off-by: Pedro Tanaka <[email protected]>
Signed-off-by: Pedro Tanaka <[email protected]>
Thanos stores can now calculate chunk hashes and send them as part of
the series response.

This commit modifies the dedup proxy to not calculate those hashes if
they are available.

Signed-off-by: Filip Petkovski <[email protected]>

Signed-off-by: Filip Petkovski <[email protected]>
The store proxy deduplicates series by calculating a hash on the each
aggregate chunk. If at least one hash is not present in the dedup-map,
the entire series chunk is added to the response, including all aggregate
chunks.

Because of this, we can short-circuit deduping chunks and stop early if any
aggregate chunks is not previously seen.

Signed-off-by: Filip Petkovski <[email protected]>

Signed-off-by: Filip Petkovski <[email protected]>
…specify metric labels to collect (thanos-io#5785)

* added unit tests for long labels and no external labels

Signed-off-by: utukj <[email protected]>

* trimmed too long external labels

Signed-off-by: utukj <[email protected]>

* added optional label selection

Signed-off-by: utukj <[email protected]>

* added cmd flag for choosing metric labels

Signed-off-by: utukj <[email protected]>

* updated docs

Signed-off-by: utukj <[email protected]>

* Update pkg/query/endpointset.go

full sentence fix

Co-authored-by: Bartlomiej Plotka <[email protected]>
Signed-off-by: Uwakmfon Utuk <[email protected]>

* Update pkg/query/endpointset.go

Co-authored-by: Bartlomiej Plotka <[email protected]>
Signed-off-by: Uwakmfon Utuk <[email protected]>

* minor fixes from code review

Signed-off-by: utukj <[email protected]>

* fixed code comments

Signed-off-by: utukj <[email protected]>

* used enum for labels

Signed-off-by: utukj <[email protected]>

* updated query docs

Signed-off-by: utukj <[email protected]>

* cleaned up tests

Signed-off-by: utukj <[email protected]>

* Updates busybox SHA (thanos-io#5793)

Signed-off-by: GitHub <[email protected]>

Signed-off-by: GitHub <[email protected]>
Co-authored-by: yeya24 <[email protected]>
Signed-off-by: utukj <[email protected]>

* Receive: Reload tenant limit configuration on file change (thanos-io#5673)

* Create a PathOrContent reloader

Signed-off-by: Douglas Camata <[email protected]>

* Add docs to staticPathContent.Rewrite

Signed-off-by: Douglas Camata <[email protected]>

* Run goimports

Signed-off-by: Douglas Camata <[email protected]>

* Properly cancel the context in the test

Signed-off-by: Douglas Camata <[email protected]>

* Watch parent directory of file

This helps handling deletes and other situations.

Signed-off-by: Douglas Camata <[email protected]>

* Remove useless ctx.Done()

Signed-off-by: Douglas Camata <[email protected]>

* Add a debounce timer to config reload

It helps managing situations where a create event is followed by a write or when a big file write is sent by the fsnotify backend as many write events.

Signed-off-by: Douglas Camata <[email protected]>

* Fix event.Op bitmask check

Signed-off-by: Douglas Camata <[email protected]>

* Update lastReload

Signed-off-by: Douglas Camata <[email protected]>

* Fix debouncer for path content reloader

Signed-off-by: Douglas Camata <[email protected]>

* Improve documentation of the PathContentRealoder

Signed-off-by: Douglas Camata <[email protected]>

* Dain reload timer before resetting

Signed-off-by: Douglas Camata <[email protected]>

* Run tests in parallel

Signed-off-by: Douglas Camata <[email protected]>

* Simplify debouncing logic

Signed-off-by: Douglas Camata <[email protected]>

* Add more tests to file reloader

Signed-off-by: Douglas Camata <[email protected]>

* Simplify condition for triggering reload

Signed-off-by: Douglas Camata <[email protected]>

* Use absolute path to config file

Signed-off-by: Douglas Camata <[email protected]>

* Get rid of parallel test

Signed-off-by: Douglas Camata <[email protected]>

* Put back 2s wait between fs operations

Signed-off-by: Douglas Camata <[email protected]>

* Remove useless sleep

Signed-off-by: Douglas Camata <[email protected]>

* Stop reloadTimer when context cancelled

Signed-off-by: Douglas Camata <[email protected]>

* Remove unused fucntion

Signed-off-by: Douglas Camata <[email protected]>

* Add missing copyright to test file

Signed-off-by: Douglas Camata <[email protected]>

* Auto-reload tenant limit config on file changes

Signed-off-by: Douglas Camata <[email protected]>

* Wrap error when reloading config

Signed-off-by: Douglas Camata <[email protected]>

* Move limiter config reloader and update logs

Signed-off-by: Douglas Camata <[email protected]>

* Get rid of useless types and allocations

Signed-off-by: Douglas Camata <[email protected]>

* Remove errorChan from config reload starter

Signed-off-by: Douglas Camata <[email protected]>

* Retrigger CI

Signed-off-by: Douglas Camata <[email protected]>

* Use UnRegisterer in the Limiter

To ensure that limit reloads will be able to re-register their metrics.

Signed-off-by: Douglas Camata <[email protected]>

* Better guard against nil registerer in the limiter

Signed-off-by: Douglas Camata <[email protected]>

* Remove wrong nil guard

Signed-off-by: Douglas Camata <[email protected]>

* Retrigger CI

Signed-off-by: Douglas Camata <[email protected]>

Signed-off-by: Douglas Camata <[email protected]>
Signed-off-by: utukj <[email protected]>

* Query: add query metrics to calls going through the Store API (thanos-io#5741)

* Implement granular query performance metrics for Thanos Query

These are grabbed from the data returned by multiple Store APIs after execution of a query.

Signed-off-by: Douglas Camata <[email protected]>

* Fix some linter warnings

Signed-off-by: Douglas Camata <[email protected]>

* Remove useless logs

Signed-off-by: Douglas Camata <[email protected]>

* Refactor query tests

Signed-off-by: Douglas Camata <[email protected]>

* Fix long function definition (newQuerier)

Signed-off-by: Douglas Camata <[email protected]>

* Remove TODO comment

Signed-off-by: Douglas Camata <[email protected]>

* Fix query tests

Signed-off-by: Douglas Camata <[email protected]>

* Reformat query docs

Signed-off-by: Douglas Camata <[email protected]>

* Remove useless return

Signed-off-by: Douglas Camata <[email protected]>

* Put back old query docs

Signed-off-by: Douglas Camata <[email protected]>

* Update query docs again

Signed-off-by: Douglas Camata <[email protected]>

* Fix e2e env name

Signed-off-by: Douglas Camata <[email protected]>

* Retrigger CI

Signed-off-by: Douglas Camata <[email protected]>

* Add missing copyright notice.

Signed-off-by: Douglas Camata <[email protected]>

* Retrigger CI

Signed-off-by: Douglas Camata <[email protected]>

* Retrigger CI

Signed-off-by: Douglas Camata <[email protected]>

* Bump wait time to twice scrape interval

Signed-off-by: Douglas Camata <[email protected]>

* Retrigger CI

Signed-off-by: Douglas Camata <[email protected]>

* Attempt to fix randomly failing test

Signed-off-by: Douglas Camata <[email protected]>

* Checking more metrics to ensure the store is ready

Signed-off-by: Douglas Camata <[email protected]>

* Clean up test

Signed-off-by: Douglas Camata <[email protected]>

* Do not record store api metrics when didn't touch series or samples

Signed-off-by: Douglas Camata <[email protected]>

* Retrigger CI

Signed-off-by: Douglas Camata <[email protected]>

* Also skip store api metrics on zero chunks touched

Signed-off-by: Douglas Camata <[email protected]>

* Update changelog

Signed-off-by: Douglas Camata <[email protected]>

* Fix broken changelog after merge

Signed-off-by: Douglas Camata <[email protected]>

* Remove extra empty line

Signed-off-by: Douglas Camata <[email protected]>

* Refactor names and (un)exported types and fields

Signed-off-by: Douglas Camata <[email protected]>

* Start listing metrics exported by Thanos Query

Signed-off-by: Douglas Camata <[email protected]>

* Rename pkg/store/metrics -> pkg/store/telemetry

Signed-off-by: Douglas Camata <[email protected]>

* Get rid of the pkg/store/telemetry package

Signed-off-by: Douglas Camata <[email protected]>

Signed-off-by: Douglas Camata <[email protected]>
Signed-off-by: Matej Gera <[email protected]>
Co-authored-by: Matej Gera <[email protected]>
Signed-off-by: utukj <[email protected]>

* docs: mark me as shepherd for next release (thanos-io#5797)

Let's release the RC on Friday.

Signed-off-by: Giedrius Statkevičius <[email protected]>

Signed-off-by: Giedrius Statkevičius <[email protected]>
Signed-off-by: utukj <[email protected]>

* Revert "docs: mark me as shepherd for next release (thanos-io#5797)"

This reverts commit ea646a6.

Signed-off-by: utukj <[email protected]>

* Revert "Query: add query metrics to calls going through the Store API (thanos-io#5741)"

This reverts commit eec4fd0.

Signed-off-by: utukj <[email protected]>

* Revert "Receive: Reload tenant limit configuration on file change (thanos-io#5673)"

This reverts commit 24e1cc0.

Signed-off-by: utukj <[email protected]>

* Revert "Updates busybox SHA (thanos-io#5793)"

This reverts commit 9474c00.

Signed-off-by: utukj <[email protected]>

* Updates busybox SHA (thanos-io#5793)

Signed-off-by: GitHub <[email protected]>

Signed-off-by: GitHub <[email protected]>
Co-authored-by: yeya24 <[email protected]>
Signed-off-by: utukj <[email protected]>

* Receive: Reload tenant limit configuration on file change (thanos-io#5673)

* Create a PathOrContent reloader

Signed-off-by: Douglas Camata <[email protected]>

* Add docs to staticPathContent.Rewrite

Signed-off-by: Douglas Camata <[email protected]>

* Run goimports

Signed-off-by: Douglas Camata <[email protected]>

* Properly cancel the context in the test

Signed-off-by: Douglas Camata <[email protected]>

* Watch parent directory of file

This helps handling deletes and other situations.

Signed-off-by: Douglas Camata <[email protected]>

* Remove useless ctx.Done()

Signed-off-by: Douglas Camata <[email protected]>

* Add a debounce timer to config reload

It helps managing situations where a create event is followed by a write or when a big file write is sent by the fsnotify backend as many write events.

Signed-off-by: Douglas Camata <[email protected]>

* Fix event.Op bitmask check

Signed-off-by: Douglas Camata <[email protected]>

* Update lastReload

Signed-off-by: Douglas Camata <[email protected]>

* Fix debouncer for path content reloader

Signed-off-by: Douglas Camata <[email protected]>

* Improve documentation of the PathContentRealoder

Signed-off-by: Douglas Camata <[email protected]>

* Dain reload timer before resetting

Signed-off-by: Douglas Camata <[email protected]>

* Run tests in parallel

Signed-off-by: Douglas Camata <[email protected]>

* Simplify debouncing logic

Signed-off-by: Douglas Camata <[email protected]>

* Add more tests to file reloader

Signed-off-by: Douglas Camata <[email protected]>

* Simplify condition for triggering reload

Signed-off-by: Douglas Camata <[email protected]>

* Use absolute path to config file

Signed-off-by: Douglas Camata <[email protected]>

* Get rid of parallel test

Signed-off-by: Douglas Camata <[email protected]>

* Put back 2s wait between fs operations

Signed-off-by: Douglas Camata <[email protected]>

* Remove useless sleep

Signed-off-by: Douglas Camata <[email protected]>

* Stop reloadTimer when context cancelled

Signed-off-by: Douglas Camata <[email protected]>

* Remove unused fucntion

Signed-off-by: Douglas Camata <[email protected]>

* Add missing copyright to test file

Signed-off-by: Douglas Camata <[email protected]>

* Auto-reload tenant limit config on file changes

Signed-off-by: Douglas Camata <[email protected]>

* Wrap error when reloading config

Signed-off-by: Douglas Camata <[email protected]>

* Move limiter config reloader and update logs

Signed-off-by: Douglas Camata <[email protected]>

* Get rid of useless types and allocations

Signed-off-by: Douglas Camata <[email protected]>

* Remove errorChan from config reload starter

Signed-off-by: Douglas Camata <[email protected]>

* Retrigger CI

Signed-off-by: Douglas Camata <[email protected]>

* Use UnRegisterer in the Limiter

To ensure that limit reloads will be able to re-register their metrics.

Signed-off-by: Douglas Camata <[email protected]>

* Better guard against nil registerer in the limiter

Signed-off-by: Douglas Camata <[email protected]>

* Remove wrong nil guard

Signed-off-by: Douglas Camata <[email protected]>

* Retrigger CI

Signed-off-by: Douglas Camata <[email protected]>

Signed-off-by: Douglas Camata <[email protected]>
Signed-off-by: utukj <[email protected]>

* Query: add query metrics to calls going through the Store API (thanos-io#5741)

* Implement granular query performance metrics for Thanos Query

These are grabbed from the data returned by multiple Store APIs after execution of a query.

Signed-off-by: Douglas Camata <[email protected]>

* Fix some linter warnings

Signed-off-by: Douglas Camata <[email protected]>

* Remove useless logs

Signed-off-by: Douglas Camata <[email protected]>

* Refactor query tests

Signed-off-by: Douglas Camata <[email protected]>

* Fix long function definition (newQuerier)

Signed-off-by: Douglas Camata <[email protected]>

* Remove TODO comment

Signed-off-by: Douglas Camata <[email protected]>

* Fix query tests

Signed-off-by: Douglas Camata <[email protected]>

* Reformat query docs

Signed-off-by: Douglas Camata <[email protected]>

* Remove useless return

Signed-off-by: Douglas Camata <[email protected]>

* Put back old query docs

Signed-off-by: Douglas Camata <[email protected]>

* Update query docs again

Signed-off-by: Douglas Camata <[email protected]>

* Fix e2e env name

Signed-off-by: Douglas Camata <[email protected]>

* Retrigger CI

Signed-off-by: Douglas Camata <[email protected]>

* Add missing copyright notice.

Signed-off-by: Douglas Camata <[email protected]>

* Retrigger CI

Signed-off-by: Douglas Camata <[email protected]>

* Retrigger CI

Signed-off-by: Douglas Camata <[email protected]>

* Bump wait time to twice scrape interval

Signed-off-by: Douglas Camata <[email protected]>

* Retrigger CI

Signed-off-by: Douglas Camata <[email protected]>

* Attempt to fix randomly failing test

Signed-off-by: Douglas Camata <[email protected]>

* Checking more metrics to ensure the store is ready

Signed-off-by: Douglas Camata <[email protected]>

* Clean up test

Signed-off-by: Douglas Camata <[email protected]>

* Do not record store api metrics when didn't touch series or samples

Signed-off-by: Douglas Camata <[email protected]>

* Retrigger CI

Signed-off-by: Douglas Camata <[email protected]>

* Also skip store api metrics on zero chunks touched

Signed-off-by: Douglas Camata <[email protected]>

* Update changelog

Signed-off-by: Douglas Camata <[email protected]>

* Fix broken changelog after merge

Signed-off-by: Douglas Camata <[email protected]>

* Remove extra empty line

Signed-off-by: Douglas Camata <[email protected]>

* Refactor names and (un)exported types and fields

Signed-off-by: Douglas Camata <[email protected]>

* Start listing metrics exported by Thanos Query

Signed-off-by: Douglas Camata <[email protected]>

* Rename pkg/store/metrics -> pkg/store/telemetry

Signed-off-by: Douglas Camata <[email protected]>

* Get rid of the pkg/store/telemetry package

Signed-off-by: Douglas Camata <[email protected]>

Signed-off-by: Douglas Camata <[email protected]>
Signed-off-by: Matej Gera <[email protected]>
Co-authored-by: Matej Gera <[email protected]>
Signed-off-by: utukj <[email protected]>

* docs: mark me as shepherd for next release (thanos-io#5797)

Let's release the RC on Friday.

Signed-off-by: Giedrius Statkevičius <[email protected]>

Signed-off-by: Giedrius Statkevičius <[email protected]>
Signed-off-by: utukj <[email protected]>

* Revert "docs: mark me as shepherd for next release (thanos-io#5797)"

This reverts commit c509c0e.

Signed-off-by: utukj <[email protected]>

* Revert "Updates busybox SHA (thanos-io#5793)"

This reverts commit ad11a03.

Signed-off-by: utukj <[email protected]>

* Revert "Query: add query metrics to calls going through the Store API (thanos-io#5741)"

This reverts commit 7a77769.

Signed-off-by: utukj <[email protected]>

* Revert "Receive: Reload tenant limit configuration on file change (thanos-io#5673)"

This reverts commit 32ca327.

Signed-off-by: utukj <[email protected]>

* fixed lint issue

Signed-off-by: utukj <[email protected]>

* added unit test for truncate and clean up

Signed-off-by: utukj <[email protected]>

* fixed truncate label func and added more tests

Signed-off-by: utukj <[email protected]>

* removed name from truncate test

Signed-off-by: utukj <[email protected]>

* reorganized test cases and removed redundant comments

Signed-off-by: utukj <[email protected]>

* Update pkg/query/endpointset_test.go

Co-authored-by: Bartlomiej Plotka <[email protected]>
Signed-off-by: Uwakmfon Utuk <[email protected]>

* Update pkg/query/endpointset.go

Co-authored-by: Bartlomiej Plotka <[email protected]>
Signed-off-by: Uwakmfon Utuk <[email protected]>

* fixed failing checks

Signed-off-by: utukj <[email protected]>

* e2e: Adding test for querier with two stores loadbalancing across them.

Signed-off-by: bwplotka <[email protected]>

* Update pkg/query/endpointset_test.go

Co-authored-by: Bartlomiej Plotka <[email protected]>
Signed-off-by: Uwakmfon Utuk <[email protected]>

* dumped long expected output in unittest

Signed-off-by: utukj <[email protected]>

* Revert "e2e: Adding test for querier with two stores loadbalancing across them."

This reverts commit 96b1545.

Signed-off-by: utukj <[email protected]>

* Update pkg/query/endpointset_test.go

Co-authored-by: Bartlomiej Plotka <[email protected]>
Signed-off-by: Uwakmfon Utuk <[email protected]>

* Update pkg/query/endpointset_test.go

Co-authored-by: Bartlomiej Plotka <[email protected]>
Signed-off-by: Uwakmfon Utuk <[email protected]>

* moved label definition to endpointset

Signed-off-by: utukj <[email protected]>

Signed-off-by: utukj <[email protected]>
Signed-off-by: Uwakmfon Utuk <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: Douglas Camata <[email protected]>
Signed-off-by: Matej Gera <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>
Signed-off-by: bwplotka <[email protected]>
Co-authored-by: Bartlomiej Plotka <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: yeya24 <[email protected]>
Co-authored-by: Douglas Camata <[email protected]>
Co-authored-by: Matej Gera <[email protected]>
Co-authored-by: Giedrius Statkevičius <[email protected]>
* store: add downloaded bytes limit

Signed-off-by: Giedrius Statkevičius <[email protected]>

* store: add bytesLimiter to LabelNames, LabelValues

Signed-off-by: Giedrius Statkevičius <[email protected]>

* test: add e2e test for new limiter

Signed-off-by: Giedrius Statkevičius <[email protected]>

* *: update CHANGELOG/etc

Signed-off-by: Giedrius Statkevičius <[email protected]>

* e2e: hard fail on no error

We always expect an error here.

Signed-off-by: Giedrius Statkevičius <[email protected]>

* CHANGELOG: fix & improve clarity

Signed-off-by: Giedrius Statkevičius <[email protected]>

Signed-off-by: Giedrius Statkevičius <[email protected]>
Signed-off-by: Matej Gera <[email protected]>

Signed-off-by: Matej Gera <[email protected]>
…anos-io#5831)

* Fix test depending on example rules

Signed-off-by: Matej Gera <[email protected]>

* Add CHANGELOG

Signed-off-by: Matej Gera <[email protected]>

Signed-off-by: Matej Gera <[email protected]>
* update recieve.md doc

Signed-off-by: rajivharlalka <[email protected]>

* Retrigger CI

Signed-off-by: rajivharlalka <[email protected]>

* Update docs/components/receive.md

Co-authored-by: Saswata Mukherjee <[email protected]>
Signed-off-by: Rajiv Harlalka <[email protected]>

* Update docs/components/receive.md

Co-authored-by: Saswata Mukherjee <[email protected]>
Signed-off-by: Rajiv Harlalka <[email protected]>

* fix recieve readme white-spaces

Signed-off-by: rajivharlalka <[email protected]>

Signed-off-by: rajivharlalka <[email protected]>
Signed-off-by: Rajiv Harlalka <[email protected]>
Signed-off-by: Matej Gera <[email protected]>
Co-authored-by: Saswata Mukherjee <[email protected]>
Co-authored-by: Matej Gera <[email protected]>
…5568)

* docs: Added guide for Community Office Hours shepherding.

Signed-off-by: bwplotka <[email protected]>

* Update docs/contributing/community.md

Signed-off-by: Matej Gera <[email protected]>

* Fix whitespaces

Signed-off-by: Matej Gera <[email protected]>

Signed-off-by: bwplotka <[email protected]>
Signed-off-by: Matej Gera <[email protected]>
Signed-off-by: Matej Gera <[email protected]>
Co-authored-by: Matej Gera <[email protected]>
Co-authored-by: Matej Gera <[email protected]>
Signed-off-by: Matej Gera <[email protected]>

Signed-off-by: Matej Gera <[email protected]>
* Add experimental snapshot on shutdown to receive

Signed-off-by: Matej Gera <[email protected]>

* Add CHANGELOG

Signed-off-by: Matej Gera <[email protected]>

Signed-off-by: Matej Gera <[email protected]>
…records too (thanos-io#5716)

* feat: cname handling in lookupsrv

Signed-off-by: Atharva Shinde <[email protected]>

* deleted: redundant var

Signed-off-by: Atharva Shinde <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Atharva Shinde <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Atharva Shinde <[email protected]>

Signed-off-by: Atharva Shinde <[email protected]>
Signed-off-by: Matej Gera <[email protected]>
Co-authored-by: Matej Gera <[email protected]>
* Add flag to specify out-of-order time window

Signed-off-by: Matej Gera <[email protected]>

* Handle new sample error

Signed-off-by: Matej Gera <[email protected]>

* Adjust CHANGELOG

Signed-off-by: Matej Gera <[email protected]>

* Add out-of-order cap max parameter

Signed-off-by: Matej Gera <[email protected]>

* Update docs

Signed-off-by: Matej Gera <[email protected]>

* Add warning about enabling vertical compaction

Signed-off-by: Matej Gera <[email protected]>

Signed-off-by: Matej Gera <[email protected]>
…s-io#5844)

* apply @ modifier start and end in QF split interval middleware

Signed-off-by: Ben Ye <[email protected]>

* fix lint

Signed-off-by: Ben Ye <[email protected]>

* fix unit tests

Signed-off-by: Ben Ye <[email protected]>

Signed-off-by: Ben Ye <[email protected]>
* shard subqueries

Signed-off-by: Ben Ye <[email protected]>

* update changelog

Signed-off-by: Ben Ye <[email protected]>

Signed-off-by: Ben Ye <[email protected]>
* support lookback_delta on query frontend and add it as part of the cache key

Signed-off-by: Ben Ye <[email protected]>

* update changelog

Signed-off-by: Ben Ye <[email protected]>

Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Matej Gera <[email protected]>

Signed-off-by: Matej Gera <[email protected]>
Signed-off-by: Seena Fallah <[email protected]>

Signed-off-by: Seena Fallah <[email protected]>
* adds medallia blog post

* fix-typo

instant-query-latency.png rather than instance-query-latency.png

* Add files via upload

* Update 2022-09-08-thanos-at-medallia.md

* Delete architecture.png

* Add files via upload

* Update 2022-09-08-thanos-at-medallia.md

* Moved images in correct place + lint.

Signed-off-by: bwplotka <[email protected]>

Signed-off-by: bwplotka <[email protected]>
Co-authored-by: Vic Thomas <[email protected]>
Co-authored-by: bwplotka <[email protected]>
fpetkovski and others added 22 commits December 14, 2022 17:12
* Fix mint and maxt for api/v1/series call

The storage querier currently uses select hints to set the start
and end time of the series select rpc. The same rpc is also used
for the api/v1/series API which does not produce any hints.

This commit changes the querier to use the mint and maxt from the
query itself when selecting series from stores.

Signed-off-by: Filip Petkovski <[email protected]>

* Add CHANGELOG entry

Signed-off-by: Filip Petkovski <[email protected]>

Signed-off-by: Filip Petkovski <[email protected]>
Signed-off-by: Jatin <[email protected]>

Signed-off-by: Jatin <[email protected]>
Co-authored-by: Jatin <[email protected]>
* Fix quorum calculation for Ketama hashring

The quorum calculation is currently broken when using the Ketama
hashring. The reasons are explained in detail in issue
thanos-io#5784.

This commit fixes quorum calculation by tracking successfull writes
for each individual time-series inside a remote-write request.

The commit also removes the replicate() method inside the Handler
and moves the entire logic of fanning out and calculating success
into the fanoutForward() method.

Signed-off-by: Filip Petkovski <[email protected]>

* Fix error propagation

Signed-off-by: fpetkovski <[email protected]>

* Fix writer errors

Signed-off-by: fpetkovski <[email protected]>

* Separate write from replication errors

Signed-off-by: fpetkovski <[email protected]>

* Add back replication metric

Signed-off-by: Filip Petkovski <[email protected]>

* Address PR comments

Signed-off-by: Filip Petkovski <[email protected]>

* Address code review comments

Signed-off-by: Filip Petkovski <[email protected]>

Signed-off-by: Filip Petkovski <[email protected]>
Signed-off-by: fpetkovski <[email protected]>
Print some Grafana specific headers in the slow query log if they exist.
See this [pull request](grafana/grafana#60301)
for more info.

Signed-off-by: Giedrius Statkevičius <[email protected]>
…rontend

cortex/transport: print grafana data if exists
Fix races around reading `e.endpoints`. Example race:

```
==================
WARNING: DATA RACE
Write at 0x00c00006a668 by main goroutine:
  github.com/thanos-io/thanos/pkg/query.(*EndpointSet).Close()
      /home/giedrius/dev/thanos/pkg/query/endpointset.go:582 +0x164
  main.runQuery.func3()
      /home/giedrius/dev/thanos/cmd/thanos/query.go:534 +0x44
  github.com/oklog/run.(*Group).Run()
      /home/giedrius/go/pkg/mod/github.com/oklog/[email protected]/group.go:47 +0x1ce
  main.main()
      /home/giedrius/dev/thanos/cmd/thanos/main.go:159 +0x2669

Previous read at 0x00c00006a668 by goroutine 276:
  github.com/thanos-io/thanos/pkg/query.(*EndpointSet).Update()
      /home/giedrius/dev/thanos/pkg/query/endpointset.go:396 +0xb9d
  main.runQuery.func2.1()
      /home/giedrius/dev/thanos/cmd/thanos/query.go:529 +0x4c
  github.com/thanos-io/thanos/pkg/runutil.Repeat()
      /home/giedrius/dev/thanos/pkg/runutil/runutil.go:74 +0xd8
  main.runQuery.func2()
      /home/giedrius/dev/thanos/cmd/thanos/query.go:528 +0x99
  github.com/oklog/run.(*Group).Run.func1()
      /home/giedrius/go/pkg/mod/github.com/oklog/[email protected]/group.go:38 +0x41
  github.com/oklog/run.(*Group).Run.func2()
      /home/giedrius/go/pkg/mod/github.com/oklog/[email protected]/group.go:39 +0x58

Goroutine 276 (running) created at:
  github.com/oklog/run.(*Group).Run()
      /home/giedrius/go/pkg/mod/github.com/oklog/[email protected]/group.go:37 +0x349
  main.main()
      /home/giedrius/dev/thanos/cmd/thanos/main.go:159 +0x2669
==================
```

Signed-off-by: Giedrius Statkevičius <[email protected]>

Signed-off-by: Giedrius Statkevičius <[email protected]>
Signed-off-by: GitHub <[email protected]>

Signed-off-by: GitHub <[email protected]>
Co-authored-by: yeya24 <[email protected]>
* Updated prometheus to v0.40.1

Signed-off-by: Sebastian Rabenhorst <[email protected]>

Fixed pkg

Signed-off-by: Sebastian Rabenhorst <[email protected]>

Fixed internal

Signed-off-by: Sebastian Rabenhorst <[email protected]>

Updated weaveworks/common

Signed-off-by: Sebastian Rabenhorst <[email protected]>

Fixed tests

Signed-off-by: Sebastian Rabenhorst <[email protected]>

Fixed some querier tests and commented out log spam

Signed-off-by: Sebastian Rabenhorst <[email protected]>

Fixed querier test

Signed-off-by: Sebastian Rabenhorst <[email protected]>

Reverted tls integration test

Signed-off-by: Sebastian Rabenhorst <[email protected]>

Fixed TestChunkQueryable

Signed-off-by: Sebastian Rabenhorst <[email protected]>

Implemented pushdownSeriesIterator AtT fn

Signed-off-by: Sebastian Rabenhorst <[email protected]>

Fixed cloudtrace import

Signed-off-by: Sebastian Rabenhorst <[email protected]>

Ran go mod tidy

Signed-off-by: Sebastian Rabenhorst <[email protected]>

trigger tests

Signed-off-by: Sebastian Rabenhorst <[email protected]>

* Uncommented log line

Signed-off-by: Sebastian Rabenhorst <[email protected]>

* Removed TODOs and fixed test message

Signed-off-by: Sebastian Rabenhorst <[email protected]>

* Updated prom engine

Signed-off-by: Sebastian Rabenhorst <[email protected]>

* Added missing nil check for delSeriesIterator and comment

Signed-off-by: Sebastian Rabenhorst <[email protected]>

* Fixed comment

Signed-off-by: Sebastian Rabenhorst <[email protected]>

* Started working on e2e tests

Signed-off-by: Sebastian Rabenhorst <[email protected]>

* Added native histograms e2e tests

Signed-off-by: Sebastian Rabenhorst <[email protected]>

* Updated

Signed-off-by: Sebastian Rabenhorst <[email protected]>

* Added license header to native histogram tests

Signed-off-by: Sebastian Rabenhorst <[email protected]>

* Added retry for TestQueryNativeHistograms

Signed-off-by: Sebastian Rabenhorst <[email protected]>

* Improved native histogram tests, added changelog and update prometheus to v0.40.7

Signed-off-by: Sebastian Rabenhorst <[email protected]>

* Fixed changelog

Signed-off-by: Sebastian Rabenhorst <[email protected]>

* Removed trailing space from changelog

Signed-off-by: Sebastian Rabenhorst <[email protected]>

* Ran busy box updater

Signed-off-by: Sebastian Rabenhorst <[email protected]>

Signed-off-by: Sebastian Rabenhorst <[email protected]>
…arn/pkg/ui/react-app/decode-uri-component-0.2.2

Bump decode-uri-component from 0.2.0 to 0.2.2 in /pkg/ui/react-app
* Use efficientgo/core/testutil for tests

Signed-off-by: Saswata Mukherjee <[email protected]>

* Fix lint

Signed-off-by: Saswata Mukherjee <[email protected]>

* Add nolint for gosec warnings

Signed-off-by: Saswata Mukherjee <[email protected]>

* Use testutil.ContainsStringSlice

Signed-off-by: Saswata Mukherjee <[email protected]>

* Remove efficientgo/tools/core

Signed-off-by: Saswata Mukherjee <[email protected]>

* Fix after rebase

Signed-off-by: Saswata Mukherjee <[email protected]>

Signed-off-by: Saswata Mukherjee <[email protected]>
Signed-off-by: Kama Huang <[email protected]>

Signed-off-by: Kama Huang <[email protected]>
Signed-off-by: Douglas Camata <[email protected]>
…amples-rate

mixin(Receive): Fix series/samples written rate
* cacheutil: replace go-redis with rueidis client

Switch client to rueidis because it is faster and supports client-side
caching. Tested it in production for a few months.

Signed-off-by: Giedrius Statkevičius <[email protected]>

* cacheutil: fix according to review

Signed-off-by: Giedrius Statkevičius <[email protected]>

Signed-off-by: Giedrius Statkevičius <[email protected]>
Signed-off-by: Bartlomiej Plotka <[email protected]>
Co-authored-by: Bartlomiej Plotka <[email protected]>
…o-downsample or no-compact markers on the blocks. (thanos-io#5977)

Signed-off-by: maheshbaliga <[email protected]>

Signed-off-by: maheshbaliga <[email protected]>
in a favour of 86b4039 SyncMetas will retry if it's retriable.
Also, the cleanPartialMarked calls are surrounded by runutil.Repeat() will be repeated,
the ones not and are not retriable will throw an interrupt to run.Group() by returning err
and Group will call cancel() as it's configured for its interrupt func.

Signed-off-by: Seena Fallah <[email protected]>

Signed-off-by: Seena Fallah <[email protected]>
* Cut v0.30.0-rc.0

Signed-off-by: bwplotka <[email protected]>

* mdox fix.

Signed-off-by: bwplotka <[email protected]>

Signed-off-by: bwplotka <[email protected]>
Signed-off-by: JoaoBraveCoding <[email protected]>
@openshift-ci openshift-ci bot requested review from raptorsun and slashpai January 3, 2023 10:40
@openshift-ci
Copy link

openshift-ci bot commented Jan 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoaoBraveCoding

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2023
@JoaoBraveCoding
Copy link
Author

/retest-required

@openshift-ci
Copy link

openshift-ci bot commented Jan 3, 2023

@JoaoBraveCoding: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/test-local 706b773 link true /test test-local
ci/prow/e2e-agnostic-cmo 706b773 link true /test e2e-agnostic-cmo
ci/prow/e2e-aws-upgrade 706b773 link true /test e2e-aws-upgrade
ci/prow/e2e-aws 706b773 link true /test e2e-aws
ci/prow/images 706b773 link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/thanos that referenced this pull request Jan 10, 2025
* update component version to 2.10

Signed-off-by: Subbarao Meduri <[email protected]>

* update busybox versions

Signed-off-by: Subbarao Meduri <[email protected]>

---------

Signed-off-by: Subbarao Meduri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.