App crash on multiple button clicks #277
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… quick succession
…s on the record weight button
…OpenSRP/opensrp-client-path into 266-app-crash-on-multiple-button-clicks
Signed-off-by: Ephraim Muhia <[email protected]> Co-authored-by: Vincent Karuri <[email protected]>
1. Added the utility to Utils 2. Refactored ChildDetailTabbedActivity, ChildImmunizationActivity, HIA2ReportsActivity, NotInCatchmentDialogFragment, SetCsoDialogFragment, ChildUnderFiveFragment to use the new util 3. ChildDetailTabbedActivity returns false if dialog fails to open, line 416
1. Add instance variable lastDialogOpened to the DuplicateDialogGuard 2. Remove lastDialogOpened instance variable from classes that previously had it 3. Set the dialogTag to a global DIALOG_TAG that is unique per fragment or activity 4. Remove dialogOpen instance variable from classes that previously had it 5. Adjust PROHIBITED_INTERVAL value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug can be reproduced by applying multiple, quick and successive clicks to the record weight button, the growth chart button or the service card labels - all in the Child Immunization activity.
At the moment, such clicks cause the app to crash.
This fix prevents multiple instances of the same dialog fragment type from being opened if one already exists.
See more at #266