-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update vexctl to spec v0.2.0 #92
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puerco
changed the title
WIP: Update vexctl to first revision of spec
WIP: Update vexctl to spec v0.2.0
Aug 8, 2023
puerco
force-pushed
the
opevs
branch
3 times, most recently
from
August 17, 2023 04:52
4b06b6b
to
a897977
Compare
puerco
changed the title
WIP: Update vexctl to spec v0.2.0
Update vexctl to spec v0.2.0
Aug 17, 2023
OK, this one should be ready for review. Update: Rebase done, ready to go 🚀 |
puerco
added
enhancement
New feature or request
go
Pull requests that update Go code
labels
Aug 17, 2023
This was referenced Aug 18, 2023
Merged
puerco
force-pushed
the
opevs
branch
4 times, most recently
from
August 24, 2023 20:35
02c3693
to
619569d
Compare
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
This commit udpates and improves the project's tests to work with the new spec v0.2.0. It also adds various new documents to widen the test cases and ensure compatibility with the previous spec version. Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
cpanato
approved these changes
Aug 25, 2023
Thanks @cpanato !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compatibility is completely maintained except for one detail:
vexctl create
can no longer take multiple products. As the subcomponents are now bound to the product, there are no good CLI ergonomics to support multiple products. Soon we will havevexctl add
which will allow for incremental composition of documents via the CLI.It needs openvex/go-vex#45 openvex/go-vex#49 to merge and an update to go.mod to pull the changes and drop a local replacement.Signed-off-by: Adolfo García Veytia (Puerco) [email protected]