Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vexctl to spec v0.2.0 #92

Merged
merged 6 commits into from
Aug 25, 2023
Merged

Update vexctl to spec v0.2.0 #92

merged 6 commits into from
Aug 25, 2023

Conversation

puerco
Copy link
Member

@puerco puerco commented Jul 10, 2023

This pull request introduces changes to implement the v0.2.0 revision of the OpenVEX spec in vexctl.

Compatibility is completely maintained except for one detail:

vexctl create can no longer take multiple products. As the subcomponents are now bound to the product, there are no good CLI ergonomics to support multiple products. Soon we will have vexctl add which will allow for incremental composition of documents via the CLI.

It needs openvex/go-vex#45 openvex/go-vex#49 to merge and an update to go.mod to pull the changes and drop a local replacement.

Signed-off-by: Adolfo García Veytia (Puerco) [email protected]

@puerco puerco changed the title WIP: Update vexctl to first revision of spec WIP: Update vexctl to spec v0.2.0 Aug 8, 2023
@puerco puerco force-pushed the opevs branch 3 times, most recently from 4b06b6b to a897977 Compare August 17, 2023 04:52
@puerco puerco changed the title WIP: Update vexctl to spec v0.2.0 Update vexctl to spec v0.2.0 Aug 17, 2023
@puerco
Copy link
Member Author

puerco commented Aug 17, 2023

OK, this one should be ready for review. Tests are failing because it needs openvex/go-vex#49 and a rebase, but changes are complete.

Update: Rebase done, ready to go 🚀

@puerco puerco requested a review from luhring August 17, 2023 04:59
@puerco puerco added enhancement New feature or request go Pull requests that update Go code labels Aug 17, 2023
@puerco puerco enabled auto-merge August 23, 2023 23:40
@puerco puerco mentioned this pull request Aug 24, 2023
@puerco puerco force-pushed the opevs branch 4 times, most recently from 02c3693 to 619569d Compare August 24, 2023 20:35
puerco added 6 commits August 24, 2023 14:36
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
This commit udpates and improves the project's tests to
work with the new spec v0.2.0. It also adds various new
documents to widen the test cases and ensure compatibility
with the previous spec version.

Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
@puerco puerco merged commit a2d10f3 into openvex:main Aug 25, 2023
@puerco
Copy link
Member Author

puerco commented Aug 25, 2023

Thanks @cpanato !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants