[fix] Use "path" URL kwarg in "serve_private_file" URL pattern #197

Fixes #197
openwisp · Jun 9, 2022 · 7265537 · 7265537
1 parent e166999
commit 7265537
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/openwisp_firmware_upgrader/private_storage/urls.py b/openwisp_firmware_upgrader/private_storage/urls.py
@@ -7,7 +7,11 @@
 
 urlpatterns = [
     path(
-        urljoin(IMAGE_URL_PATH, '<path:imagefile>'),
+        # Use "path" URL kwarg to make it consistent with
+        # django-private-storage. Otherwise, the S3 reverse
+        # proxy feature of django-private-storage does
+        # not work.
+        urljoin(IMAGE_URL_PATH, '<path:path>'),
         views.firmware_image_download,
         name='serve_private_file',
     ),

diff --git a/openwisp_firmware_upgrader/private_storage/views.py b/openwisp_firmware_upgrader/private_storage/views.py
@@ -8,7 +8,7 @@ class FirmwareImageDownloadView(PrivateStorageDetailView):
     model_file_field = 'file'
 
     slug_field = 'file'
-    slug_url_kwarg = 'imagefile'
+    slug_url_kwarg = 'path'
 
     def can_access_file(self, private_file):
         user = private_file.request.user