You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This breaks the functionality of PrivateS3BotoStorage which uses this URL with path keyword argument. We should change imagefile to path for consistency with private_storage module.
We have used custom URL kwarg in the
serve_private_file
URL.openwisp-firmware-upgrader/openwisp_firmware_upgrader/private_storage/urls.py
Lines 8 to 14 in e166999
openwisp-firmware-upgrader/openwisp_firmware_upgrader/private_storage/views.py
Lines 6 to 11 in e166999
This breaks the functionality of
PrivateS3BotoStorage
which uses this URL withpath
keyword argument. We should changeimagefile
topath
for consistency withprivate_storage
module.https://github.com/edoburu/django-private-storage/blob/cfe1e62e2458798760fe6f6c9825e2f663d25ac1/private_storage/storage/s3boto3.py#L58-L64
The text was updated successfully, but these errors were encountered: