Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bufix: set isPoolCacheSynced as true if lease updated #1131

Merged

Conversation

Congrool
Copy link
Member

@Congrool Congrool commented Jan 9, 2023

Signed-off-by: Congrool [email protected]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Currently, no one will set the isPoolCacheSynced as true. We should set it as ture if detecting the lease updated.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@Congrool: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

Signed-off-by: Congrool [email protected]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Currently, no one will set the isPoolCacheSynced as true. We should set it as ture if detecting the lease updated.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the kind/bug kind/bug label Jan 9, 2023
@openyurt-bot openyurt-bot added the size/XS size/XS: 0-9 label Jan 9, 2023
@Congrool
Copy link
Member Author

Congrool commented Jan 9, 2023

/hold

Need a routine to periodly check if the lease is not updated for defaultPoolCacheStaleDuration. If so, isPoolCacheSynced should be set as false.

@openyurt-bot openyurt-bot added the do-not-merge/hold do-not-merge/hold label Jan 9, 2023
@Congrool Congrool force-pushed the coordinator-poolsync-fix branch from ec52c95 to 48f6d96 Compare January 9, 2023 10:17
@openyurt-bot openyurt-bot added size/L size/L: 100-499 and removed size/XS size/XS: 0-9 labels Jan 9, 2023
@Congrool Congrool force-pushed the coordinator-poolsync-fix branch from 48f6d96 to 5402933 Compare January 9, 2023 10:23
@Congrool
Copy link
Member Author

Congrool commented Jan 9, 2023

/unhold

@openyurt-bot openyurt-bot removed the do-not-merge/hold do-not-merge/hold label Jan 9, 2023
@Congrool Congrool force-pushed the coordinator-poolsync-fix branch from 5402933 to 7b8c52e Compare January 9, 2023 10:48
@rambohe-ch rambohe-ch merged commit a5cd6e3 into openyurtio:pool-coordinator-dev Jan 10, 2023
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Congrool, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Jan 10, 2023
@Congrool Congrool deleted the coordinator-poolsync-fix branch January 12, 2023 12:55
Congrool added a commit to Congrool/openyurt that referenced this pull request Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/bug kind/bug size/L size/L: 100-499
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants