cherry-pick yurthub code of pool-coordinator-dev #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* improve health checker for adapting coordinator * add yurthub leader election and coordinator framework
* pool-coordinator implementation of yurthub Signed-off-by: Congrool <[email protected]>
…rding to secret (openyurtio#1103) * list/watch secret to get client certs Signed-off-by: Congrool <[email protected]> * add --enable-coordinator option to yurthub Signed-off-by: Congrool <[email protected]> * send SubjectAccessReview to pool-coordinator or cloud apiserver according to the group Signed-off-by: Congrool <[email protected]> * BugFix: cannot cache response Signed-off-by: Congrool <[email protected]> * do not disable nodelifecycle controller Signed-off-by: Congrool <[email protected]> * start informer factory after coordinator certMgr registering its secret informer Signed-off-by: Congrool <[email protected]>
Signed-off-by: Congrool <[email protected]> Signed-off-by: Congrool <[email protected]>
…oordinator (openyurtio#1134) Signed-off-by: Congrool <[email protected]> Signed-off-by: Congrool <[email protected]>
* Fix: pool-coordinator
) * initialize etcdClient of componentKeyCache Signed-off-by: Congrool <[email protected]>
…tio#1138) * do not wait for coordinator informer registry when coordinator is disabled Signed-off-by: Congrool <[email protected]>
Signed-off-by: Congrool <[email protected]>
Signed-off-by: Congrool <[email protected]>
) * make coordinator fields update atomic Signed-off-by: Congrool <[email protected]>
…have such resource (openyurtio#1147) Signed-off-by: Congrool <[email protected]> Signed-off-by: Congrool <[email protected]>
|
/hold Waiting for CI pass |
|
I think it's better to use |
Codecov Report
@@ Coverage Diff @@
## master #1156 +/- ##
==========================================
- Coverage 55.59% 53.99% -1.60%
==========================================
Files 98 108 +10
Lines 12881 14523 +1642
==========================================
+ Hits 7161 7842 +681
- Misses 5091 6013 +922
- Partials 629 668 +39
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rambohe-ch
approved these changes
Jan 18, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Congrool, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…rt (openyurtio#1148) * Fix: add PoolScopeResource validation and dynamic configuration support
…openyurtio#1153) * bugfix: ReplaceComponentList should not delete resources of other gvr Signed-off-by: Congrool <[email protected]>
Signed-off-by: Congrool <[email protected]>
Signed-off-by: Congrool <[email protected]>
Congrool
force-pushed
the
poolcoordinator-yurthub
branch
from
d8ddc74 to
634409d
Compare
|
/unhold |
|
Fixes #779 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Yurthub part of pool-coordinator implementation.
Functions of these code refer to: #778, #779
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
These code is cherry-picked from pool-coordinator-dev, which contains
Note:
Partial Pickmeans this pr contains other code besides yurthub component. The code of yurthub part was picked, and other code were not picked in this PR.Does this PR introduce a user-facing change?
other Note