Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: do not send pool-scoped resource list/watch request to pool-c… #1134

Merged
merged 1 commit into from
Jan 11, 2023
Merged

bugfix: do not send pool-scoped resource list/watch request to pool-c… #1134

merged 1 commit into from
Jan 11, 2023

Conversation

Congrool
Copy link
Member

…oordinator

Signed-off-by: Congrool [email protected]

What type of PR is this?

/kind bug

What this PR does / why we need it:

For pool-scoped resource list/watch request from leader-yurthub, we should always proxied it to cloud APIServer.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

@openyurt-bot
Copy link
Collaborator

@Congrool: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

…oordinator

Signed-off-by: Congrool [email protected]

What type of PR is this?

/kind bug

What this PR does / why we need it:

For pool-scoped resource list/watch request from leader-yurthub, we should always proxied it to cloud APIServer.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the size/S size/S 10-29 label Jan 10, 2023
@Congrool
Copy link
Member Author

@LaurenceLiZhixin PTAL

@rambohe-ch rambohe-ch merged commit f77c971 into openyurtio:pool-coordinator-dev Jan 11, 2023
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Congrool, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Jan 11, 2023
@Congrool Congrool deleted the coordinator-leaderproxy-fix branch January 12, 2023 12:55
Congrool added a commit to Congrool/openyurt that referenced this pull request Jan 17, 2023
@Congrool
bugfix: do not send pool-scoped resource list/watch request to pool-c…
39029b3 
…oordinator (openyurtio#1134)

Signed-off-by: Congrool <[email protected]>

Signed-off-by: Congrool <[email protected]>
@Congrool Congrool mentioned this pull request Jan 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rambohe-ch rambohe-ch rambohe-ch approved these changes

@Fei-Guo Fei-Guo Awaiting requested review from Fei-Guo

Assignees
No one assigned
Labels
approved approved size/S size/S 10-29
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Congrool @openyurt-bot @rambohe-ch