Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: pool-coordinator chart format, default service name, max body size .etc #1141

Conversation

LaurenceLiZhixin
Copy link
Member

@LaurenceLiZhixin LaurenceLiZhixin commented Jan 12, 2023

  1. Validate pool-coordinator chart to ensure it is installable.
  2. Add default pool coordinator related service name "pool-coordinator-etcd", "pool-coordinator-apiserver", and ports to yurthub default options.
  3. Add '--max-txn-ops=1000' to pool-coordinator etcd container command.
  4. Add default transfer body size between yurthub and etcd to '100M'

@openyurt-bot openyurt-bot added the size/L size/L: 100-499 label Jan 12, 2023
@LaurenceLiZhixin
Copy link
Member Author

After this pr is merged, I'll test both 'leader' and 'follower' mode at the same time, in my dev environment, with many edge nodes.
And I will add all Resources (not only endpoints and endpointslices) , as pool-scope resources, like pods, some CRDs, to test terformance optimization.

@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

❗ No coverage uploaded for pull request base (pool-coordinator-dev@7fb43e7). Click here to learn what that means.
The diff coverage is n/a.

@@                   Coverage Diff                   @@
##             pool-coordinator-dev    #1141   +/-   ##
=======================================================
  Coverage                        ?   47.83%           
=======================================================
  Files                           ?      109           
  Lines                           ?    13697           
  Branches                        ?        0           
=======================================================
  Hits                            ?     6552           
  Misses                          ?     6584           
  Partials                        ?      561           
Flag Coverage Δ
unittests 47.83% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rambohe-ch rambohe-ch merged commit 81aa62b into openyurtio:pool-coordinator-dev Jan 12, 2023
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LaurenceLiZhixin, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved size/L size/L: 100-499
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants