-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: set inElecting to false when handling follow hub, and add metrics #1145
Fix: set inElecting to false when handling follow hub, and add metrics #1145
Conversation
Codecov Report
@@ Coverage Diff @@
## pool-coordinator-dev #1145 +/- ##
=======================================================
Coverage ? 47.80%
=======================================================
Files ? 109
Lines ? 13707
Branches ? 0
=======================================================
Hits ? 6552
Misses ? 6594
Partials ? 561
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
pkg/yurthub/metrics/metrics.go
Outdated
proxyLatencyCollector *prometheus.GaugeVec | ||
poolCoordinatorYurthubRoleCollector *prometheus.GaugeVec | ||
poolCoordinatorHealthyStatusCollector *prometheus.GaugeVec | ||
poolCoordinatorReadyStatuaCollector *prometheus.GaugeVec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Statua -> Status
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
cmd/yurthub/app/start.go
Outdated
@@ -330,7 +331,7 @@ func coordinatorRun(ctx context.Context, | |||
return coordinatorTransportMgr | |||
}, func() poolcoordinator.Coordinator { | |||
return coordinator | |||
}, returnErr | |||
}, nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove the returned error, since we always return nil
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed @Congrool
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LaurenceLiZhixin, rambohe-ch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.