Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: set inElecting to false when handling follow hub, and add metrics #1145

Merged

Conversation

LaurenceLiZhixin
Copy link
Member

No description provided.

Verified

This commit was signed with the committer’s verified signature.
pamil Kamil Kokot

Verified

This commit was signed with the committer’s verified signature.
pamil Kamil Kokot
Fix

Verified

This commit was signed with the committer’s verified signature.
pamil Kamil Kokot
Fix

Verified

This commit was signed with the committer’s verified signature.
pamil Kamil Kokot
@openyurt-bot openyurt-bot added the size/L size/L: 100-499 label Jan 13, 2023
@LaurenceLiZhixin LaurenceLiZhixin changed the title Fix: set inElecting to false when handling follow hub, and add metrics [WIP] Fix: set inElecting to false when handling follow hub, and add metrics Jan 13, 2023
@openyurt-bot openyurt-bot added the do-not-merge/work-in-progress do-not-merge/work-in-progress label Jan 13, 2023
@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

❗ No coverage uploaded for pull request base (pool-coordinator-dev@d02dac7). Click here to learn what that means.
The diff coverage is n/a.

@@                   Coverage Diff                   @@
##             pool-coordinator-dev    #1145   +/-   ##
=======================================================
  Coverage                        ?   47.80%           
=======================================================
  Files                           ?      109           
  Lines                           ?    13707           
  Branches                        ?        0           
=======================================================
  Hits                            ?     6552           
  Misses                          ?     6594           
  Partials                        ?      561           
Flag Coverage Δ
unittests 47.80% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

proxyLatencyCollector *prometheus.GaugeVec
poolCoordinatorYurthubRoleCollector *prometheus.GaugeVec
poolCoordinatorHealthyStatusCollector *prometheus.GaugeVec
poolCoordinatorReadyStatuaCollector *prometheus.GaugeVec
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Statua -> Status

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@@ -330,7 +331,7 @@ func coordinatorRun(ctx context.Context,
return coordinatorTransportMgr
}, func() poolcoordinator.Coordinator {
return coordinator
}, returnErr
}, nil
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the returned error, since we always return nil

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed @Congrool

@LaurenceLiZhixin LaurenceLiZhixin changed the title [WIP] Fix: set inElecting to false when handling follow hub, and add metrics Fix: set inElecting to false when handling follow hub, and add metrics Jan 13, 2023
@openyurt-bot openyurt-bot removed the do-not-merge/work-in-progress do-not-merge/work-in-progress label Jan 13, 2023
Fix

Verified

This commit was signed with the committer’s verified signature.
pamil Kamil Kokot
@rambohe-ch rambohe-ch merged commit abf81f3 into openyurtio:pool-coordinator-dev Jan 13, 2023
@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LaurenceLiZhixin, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Jan 13, 2023
Congrool pushed a commit to Congrool/openyurt that referenced this pull request Jan 17, 2023

Verified

This commit was signed with the committer’s verified signature.
pamil Kamil Kokot
openyurtio#1145)

* fix: add metrics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved size/L size/L: 100-499
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants