Support crd.versions field #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the verify command to respect the latest crd spec with regards to the deprecation of the version field and replacement with spec.versions
openshift-ci-robot
added
the
size/XL
There was a problem hiding this comment.
I think we may need to change the ui validate stuff too (here) and in the const.py file where version is required - this could be breaking if the field isn't there.
|
This will LGTM once @gallettilance's comments are addressed. |
@gallettilance All of that stuff is about the spec.version of the CSV, not the CRD. I believe I have updated all the references to the CRD spec.version. |
|
/lgtm |
|
/approve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the verify command to respect the latest crd spec with regards to
the deprecation of the version field and replacement with spec.versions