Remove cluster-scoped flag #1434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/L
hasbro17
force-pushed
the
remove-cluster-scoped-flag
branch
from
764d948 to
f7ef2d2
Compare
joelanford
approved these changes
May 16, 2019
Co-Authored-By: Joe Lanford <[email protected]>
Co-Authored-By: Eric Stroczynski <[email protected]>
|
New changes are detected. LGTM label has been removed. |
lilic
approved these changes
May 17, 2019
| log.Info("Generating RBAC rules") | ||
|
|
||
| roleScaffold := &scaffold.Role{ | ||
| IsClusterScoped: isClusterScoped, | ||
| IsClusterScoped: false, |
There was a problem hiding this comment.
Any reason why we couldn't just remove this as well?
There was a problem hiding this comment.
@lilic I see what you mean. The default is false but I just wanted to make the default setting explicit for the helm operator since it’s the only one that needs to set this option.
This was referenced May 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Removal of
--cluster-scopedflag and consolidation of docs on how to run cluster-scoped operators.Also documents how to enable cluster-scoped CRDs.
The Helm operator will automatically scaffold a ClusterRole/ClusterRoleBinding and inform the user of this if it detects a cluster-scoped resource in the source chart when creating a new project.
Motivation for the change:
There is a general consensus that the
--cluster-scopedflag does not cover all the use cases of running operators watching different namespaces and expanding it would complicate the CLI and behavior.It's much easier to instruct users to make the small number of changes needed to enable cluster-scoped operators and cluster-scoped CRDs.
With this the default is now namespace-scoped operators.
Fixes: #890