Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #555

Merged
merged 9 commits into from
Jan 21, 2025
Merged

Conversation

Copy link

codecov bot commented Dec 2, 2024

updates:
- [github.com/PyCQA/docformatter: eb1df34 → v1.7.5](PyCQA/docformatter@eb1df34...v1.7.5)
- [github.com/astral-sh/ruff-pre-commit: v0.7.2 → v0.8.6](astral-sh/ruff-pre-commit@v0.7.2...v0.8.6)
- [github.com/executablebooks/mdformat: 0.7.18 → 0.7.21](hukkin/mdformat@0.7.18...0.7.21)
- [github.com/executablebooks/mdformat: 0.7.18 → 0.7.21](hukkin/mdformat@0.7.18...0.7.21)
- [github.com/kynan/nbstripout: 0.8.0 → 0.8.1](kynan/nbstripout@0.8.0...0.8.1)
- [github.com/pre-commit/mirrors-mypy: v1.13.0 → v1.14.1](pre-commit/mirrors-mypy@v1.13.0...v1.14.1)
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 176d480 to e2b1c54 Compare January 6, 2025 23:13
@timmens
Copy link
Member

timmens commented Jan 10, 2025

Some things to consider:

  • Docformatter issue is still not fixed

    -> Need to stick with version eb1df34

  • Numpy has made some changes around typing in its last releases

    -> Need to fix new mypy errors and warnings

  • Mypy version in pre-commit hooks and dev environment differ

    -> Need to decide whether we bump the dev version of mypy to 1.14.1 (as is used in the hooks), or fix the pre-commit version to 1.13.0 (as is currently used in the dev env)

Copy link
Member

@janosg janosg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created #556 to make sure that we don't forget to investigate the precision problems of the new L-BFGS-B implementation.

@timmens timmens merged commit 9a40583 into main Jan 21, 2025
22 checks passed
@timmens timmens deleted the pre-commit-ci-update-config branch January 21, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants