Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to enhance the check for subjects in verifyManifest #42

Closed
wangxiaoxuan273 opened this issue Nov 23, 2022 · 0 comments · Fixed by #52
Closed

Need to enhance the check for subjects in verifyManifest #42

wangxiaoxuan273 opened this issue Nov 23, 2022 · 0 comments · Fixed by #52

Comments

@wangxiaoxuan273
Copy link

wangxiaoxuan273 commented Nov 23, 2022 •
edited
Loading

Currently only the digest is checked. We also need to verify media type for subjects (they have to be manifests). Also we need to remove the existence check.
@wangxiaoxuan273 wangxiaoxuan273 changed the title Need to enhance the validate subject function. Need to enhance the check for subjects in verifyManifest Jan 4, 2023
@wangxiaoxuan273 wangxiaoxuan273 mentioned this issue Jan 4, 2023
Merged
shizhMSFT pushed a commit that referenced this issue Jan 5, 2023
@wangxiaoxuan273
fix: remove subject existence check, add media type check (#52)
474bc48 
Resolves #42 
Resolves #50 
Resolves #49

Signed-off-by: wangxiaoxuan273 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove subject existence check, add media type check
1 participant
@wangxiaoxuan273