Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Subject existence check fails when checked with References() #49

Closed
wangxiaoxuan273 opened this issue Dec 20, 2022 · 0 comments · Fixed by #52
Closed

bug: Subject existence check fails when checked with References() #49

wangxiaoxuan273 opened this issue Dec 20, 2022 · 0 comments · Fixed by #52

Comments

@wangxiaoxuan273
Copy link

wangxiaoxuan273 commented Dec 20, 2022 •
edited
Loading

This bug was reported by Wei. I have tested offline with Wei and the bug can be fixed with this pr.

  • Scenario: image manifest A has a subject, which is artifact manifest B. When pushing A to the registry, the registry returns "subject not found" while B already exists in the repository.

  • Issues and how to fix them:

  1. According to the distribution spec, subject existence check is not needed and thus should be removed.
  2. Currently, subject is included in the References() of the manifest. All elements of References() are checked for existence in a loop and it's hard to tell which element is the subject. As subject validation is different from the validation of layers, blobs and configs (all included in References()), it's better to move subject out of References().
@wangxiaoxuan273 wangxiaoxuan273 mentioned this issue Jan 4, 2023
Merged
@wangxiaoxuan273 wangxiaoxuan273 changed the title Need to look into Wei's reported bug. bug: Subject existence check fails when only checking blobstore Jan 5, 2023
@wangxiaoxuan273 wangxiaoxuan273 changed the title bug: Subject existence check fails when only checking blobstore bug: Subject existence check fails when checked with References() Jan 5, 2023
shizhMSFT pushed a commit that referenced this issue Jan 5, 2023
@wangxiaoxuan273
fix: remove subject existence check, add media type check (#52)
474bc48 
Resolves #42 
Resolves #50 
Resolves #49

Signed-off-by: wangxiaoxuan273 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove subject existence check, add media type check
1 participant
@wangxiaoxuan273