fix: fix CODEOWNERS #77
Conversation
Signed-off-by: Shiwei Zhang <[email protected]>
| * @vsoch | ||
| * @jdolitsky | ||
| * @stevelasker | ||
| * @vsoch @jdolitsky @stevelasker |
There was a problem hiding this comment.
For reference:
Are you sure this file makes sense? E.g., we are going to be asking all three people for reviews every time there is a PR. I don't think either of the last two people have been involved with the development of the project so should we perhaps instead do it by file type, or bring in some contributors that have been active?
It was a bit awkward how you merged this file before, without talking to me, just for some feedback. Thanks for pinging this time around.
There was a problem hiding this comment.
If the two others on the list are ok with this ping, the changes are OK for me.
There was a problem hiding this comment.
I don't think either of the last two people have been involved with the development of the project so should we perhaps instead do it by file type, or bring in some contributors that have been active?
Are you suggesting that just keep you (@vsoch) in the CODEOWNERS file is good enough? If so, I will update this PR accordingly.
It was a bit awkward how you merged this file before, without talking to me, just for some feedback. Thanks for pinging this time around.
Previous PR #75 was merged too fast than I thought. All owners are pinged in the #oras slack channel for both PRs (#75 and #77).
There was a problem hiding this comment.
bring in some contributors that have been active
Yes, that's exactly one of purposes of this CODEOWNERS file.
There was a problem hiding this comment.
I’m good with whatever you’d like to do.
Having multiple entries with the same path results in that only the last entry takes effect.
This PR combines multiple entries with the same path into a single entry.