Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix CODEOWNERS #77

Merged
merged 1 commit into from
Mar 4, 2023
Merged

fix: fix CODEOWNERS #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,2 @@
# Derived from OWNERS.md
* @vsoch
* @jdolitsky
* @stevelasker
* @vsoch @jdolitsky @stevelasker
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference:

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

Are you sure this file makes sense? E.g., we are going to be asking all three people for reviews every time there is a PR. I don't think either of the last two people have been involved with the development of the project so should we perhaps instead do it by file type, or bring in some contributors that have been active?

It was a bit awkward how you merged this file before, without talking to me, just for some feedback. Thanks for pinging this time around.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the two others on the list are ok with this ping, the changes are OK for me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think either of the last two people have been involved with the development of the project so should we perhaps instead do it by file type, or bring in some contributors that have been active?

Are you suggesting that just keep you (@vsoch) in the CODEOWNERS file is good enough? If so, I will update this PR accordingly.

It was a bit awkward how you merged this file before, without talking to me, just for some feedback. Thanks for pinging this time around.

Previous PR #75 was merged too fast than I thought. All owners are pinged in the #oras slack channel for both PRs (#75 and #77).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bring in some contributors that have been active

Yes, that's exactly one of purposes of this CODEOWNERS file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m good with whatever you’d like to do.