adjust code and tests to changes in Nemo.jl (#966)

oscar-system · Feb 16, 2024 · fb0520e · fb0520e
1 parent ae2997e
commit fb0520e
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 8 deletions.
diff --git a/pkg/JuliaExperimental/gap/zmodnz.g b/pkg/JuliaExperimental/gap/zmodnz.g
@@ -28,7 +28,7 @@ InstallMethod( ContextGAPNemo,
     fi;
 
     # Create the Nemo ring.
-    juliaRing:= Julia.Nemo.residue_ring( Julia.Nemo.ZZ, GAPToJulia( m ) );
+    juliaRing:= Julia.Nemo.residue_ring( Julia.Nemo.ZZ, GAPToJulia( m ) )[1];
 
     # Create the GAP wrapper.
     # Note that elements from different Nemo residue rings cannot be compared,

diff --git a/pkg/JuliaExperimental/julia/realcyc.jl b/pkg/JuliaExperimental/julia/realcyc.jl
@@ -40,7 +40,7 @@ function isPositiveRealPartCyc( coeffs::Vector )
     while true
       R::Nemo.ArbField = Nemo.ArbField( prec )
       x::Nemo.arb = arbCyc( coeffs, R )
-      if Nemo.ispositive( x )
+      if Nemo.is_positive( x )
         return ( true, prec )
       elseif Nemo.is_negative( x )
         return ( false, prec )

diff --git a/pkg/JuliaExperimental/tst/context.tst b/pkg/JuliaExperimental/tst/context.tst
@@ -140,13 +140,13 @@ gap> c:= ContextGAPNemo( f );
 gap> gap_elm:= One( f );;
 gap> elm:= GAPToNemo( c, gap_elm );;
 gap> JuliaTypeInfo( JuliaPointer( elm ) );
-"Nemo.nf_elem"
+"Nemo.AbsSimpleNumFieldElem"
 gap> NemoToGAP( c, elm ) = gap_elm;
 true
 gap> a:= RootOfDefiningPolynomial( f );;
 gap> elm:= GAPToNemo( c, a );;
 gap> JuliaTypeInfo( JuliaPointer( elm ) );
-"Nemo.nf_elem"
+"Nemo.AbsSimpleNumFieldElem"
 gap> NemoToGAP( c, elm ) = a;
 true
 gap> gap_vec:= [ a+1, a-1 ];;

diff --git a/pkg/JuliaExperimental/tst/numfield.tst b/pkg/JuliaExperimental/tst/numfield.tst
@@ -68,11 +68,11 @@ gap> Characteristic( nmat );
 gap> tr:= TraceMat( nmat );
 <<Julia: 2>>
 gap> JuliaTypeInfo( JuliaPointer( tr ) );
-"Nemo.nf_elem"
+"Nemo.AbsSimpleNumFieldElem"
 gap> det:= DeterminantMat( nmat );
 <<Julia: 1>>
 gap> JuliaTypeInfo( JuliaPointer( det ) );
-"Nemo.nf_elem"
+"Nemo.AbsSimpleNumFieldElem"
 gap> NemoToGAP( c, nmat );
 [ [ !1, 1/2*a ], [ !0, !1 ] ]
 gap> no:= GAPToNemo( c, One( f ) );

diff --git a/pkg/JuliaInterface/tst/wrapper.tst b/pkg/JuliaInterface/tst/wrapper.tst
@@ -12,8 +12,6 @@ gap> N := Objectify(type, rec());;
 gap> SetJuliaPointer(N, n);
 gap> Julia.Base.typeof(N);
 <Julia: BigInt>
-gap> N(1);
-Error, MethodError: objects of type BigInt are not callable
 
 ## wrap a Julia function
 gap> f := Objectify(type, rec());;