Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust code and tests to changes in Nemo.jl #966

Merged
merged 4 commits into from
Feb 16, 2024

Conversation

ThomasBreuer
Copy link
Member

addresses the failures that happen in #965

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Merging #966 (c818224) into master (ae2997e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head c818224 differs from pull request most recent head 6c2f7c1. Consider uploading reports for the commit 6c2f7c1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #966      +/-   ##
==========================================
+ Coverage   75.80%   75.83%   +0.02%     
==========================================
  Files          51       51              
  Lines        4187     4183       -4     
==========================================
- Hits         3174     3172       -2     
+ Misses       1013     1011       -2     
Files Coverage Δ
pkg/JuliaExperimental/gap/zmodnz.g 97.77% <100.00%> (ø)

... and 1 file with indirect coverage changes

@ThomasBreuer
Copy link
Member Author

ThomasBreuer commented Feb 14, 2024

There were funny failures in the GAP tests:
The file pkg/JuliaInterface/tst/wrapper.tst contains the lines

gap> N(1);
Error, MethodError: objects of type BigInt are not callable

where N is a Julia object of the type BigInt. This test used to pass.

Now we get failures in the two tests Julia nightly - ubuntu-latest and Julia nightly - macOS-latest.
The expected output is

Error, MethodError: objects of type BigInt are not callable
The object of type `BigInt` exists, but no method is defined for this combinat\
\
ion of argument types when trying to treat it as a callable object.
Maybe you forgot to use an operator such as *, ^, %, / etc. ?

Surprisingly, I can reproduce the failure locally with Julia 1.8.5.
(So shouldn't the problem have occurred much earlier?)

Locally, I can make the test pass by prescribing one more output line
from the several lines of the error message:

Error, MethodError: objects of type BigInt are not callable
Maybe you forgot to use an operator such as *, ^, %, / etc. ?

I have now pushed this change. Let us see what the CI test results are.

@ThomasBreuer
Copy link
Member Author

After my second commit, things are getting even more funny:
The changes from this commit affect just the test file pkg/JuliaInterface/tst/wrapper.tst.
Now (among others) the test Julia 1.6 - ubuntu-latest fails, which had passed before the second commit, and reports problems in the test file pkg/JuliaExperimental/tst/realcyc.tst.
What is going on here?

@fingolfin fingolfin enabled auto-merge (squash) February 16, 2024 13:49
@fingolfin fingolfin merged commit fb0520e into oscar-system:master Feb 16, 2024
10 of 13 checks passed
@ThomasBreuer ThomasBreuer deleted the TB_adjust_to_Nemo branch August 27, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants