-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adjust code and tests to changes in Nemo.jl #966
adjust code and tests to changes in Nemo.jl #966
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #966 +/- ##
==========================================
+ Coverage 75.80% 75.83% +0.02%
==========================================
Files 51 51
Lines 4187 4183 -4
==========================================
- Hits 3174 3172 -2
+ Misses 1013 1011 -2
|
There were funny failures in the GAP tests:
where Now we get failures in the two tests
Surprisingly, I can reproduce the failure locally with Julia 1.8.5. Locally, I can make the test pass by prescribing one more output line
I have now pushed this change. Let us see what the CI test results are. |
After my second commit, things are getting even more funny: |
addresses the failures that happen in #965