fix the availability check in Packages.install
#1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1039 +/- ##
==========================================
+ Coverage 74.34% 74.39% +0.04%
==========================================
Files 55 55
Lines 4530 4527 -3
==========================================
Hits 3368 3368
+ Misses 1162 1159 -3
|
lgoettgens
reviewed
Sep 13, 2024
src/packages.jl
Outdated
Comment on lines
275
to
276
| for inforec in getproperty(info, spec) | ||
| if version == string(getproperty(inforec, :Version)) |
There was a problem hiding this comment.
these two lines are no longer needed due to the changes below
lgoettgens
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
This seems to solve the problem with recog in oscar-system/Oscar.jl#3688 as well and seems to be a better solution than #1037
|
Thank you for the fix! A very minor point, but: next time I would recommend to "squash merge" PRs with several "fixup" commits. To avoid a bunch of extra commits on master: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #1037.
Here we try to keep the check whether a not yet loaded GAP package is already installed, i.e.,
Packages.loadwould returntrue.The previous code was wrong in the sense that it did not consider the availability of the needed packages. Now we call the right GAP function, which tests also the needed packages.