Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the availability check in Packages.install #1039

Merged
merged 2 commits into from
Sep 13, 2024
Merged

fix the availability check in Packages.install #1039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5058d4
fix the availability check in `Packages.install`
ThomasBreuer Sep 12, 2024
50f7f45
remove now unnecessary code lines
ThomasBreuer Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "GAP"
uuid = "c863536a-3901-11e9-33e7-d5cd0df7b904"
authors = ["Thomas Breuer <[email protected]>", "Sebastian Gutsche <[email protected]>", "Max Horn <[email protected]>"]
version = "0.11.2"
version = "0.11.3"

[deps]
AbstractAlgebra = "c3fe647b-3220-5bb0-a1ea-a7954cac585d"
Expand Down
8 changes: 2 additions & 6 deletions src/packages.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,12 +272,8 @@ function install(spec::String, version::String = "";
# The package is not yet loaded but may be available.
# If an available version has the required version number
# then nothing is to do.
for inforec in getproperty(info, spec)
if version == string(getproperty(inforec, :Version))
fun = getproperty(inforec, :AvailabilityTest)
fun() && return true
end
end
res = Globals.TestPackageAvailability(GapObj(spec), GapObj(version))
res !== Globals.fail && return true
end
res = Globals.InstallPackage(GapObj(spec), GapObj(version), interactive; debug)
end
Expand Down
Loading