Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use julia_gap and gap_julia in more places #127

Merged
merged 1 commit into from
Nov 6, 2018

Conversation

fingolfin
Copy link
Member

... for consistency in the auto-conversion behaviour of JuliaInterface versus
LibGAP.jl, and for ease of use.

There is more work to be done here, though, and we need to properly
document the rules for when and where which conversion is applied,
and why.

@fingolfin fingolfin requested a review from sebasguts November 4, 2018 14:22
@codecov
Copy link

codecov bot commented Nov 4, 2018

Codecov Report

Merging #127 into master will increase coverage by 0.01%.
The diff coverage is 94.11%.

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
+ Coverage   54.33%   54.34%   +0.01%     
==========================================
  Files          44       44              
  Lines        2632     2622      -10     
==========================================
- Hits         1430     1425       -5     
+ Misses       1202     1197       -5
Impacted Files Coverage Δ
JuliaInterface/gap/JuliaInterface.gi 92.59% <100%> (+0.13%) ⬆️
JuliaInterface/src/calls.c 94.26% <100%> (+0.27%) ⬆️
JuliaInterface/gap/JuliaInterface.gd 100% <100%> (ø) ⬆️
JuliaInterface/src/JuliaInterface.c 88.34% <83.33%> (+0.24%) ⬆️
JuliaInterface/read.g 92.3% <0%> (ø) ⬆️
JuliaInterface/init.g 72.09% <0%> (ø) ⬆️
JuliaInterface/src/convert.c 95% <0%> (+15%) ⬆️

sebasguts
sebasguts previously approved these changes Nov 5, 2018
Copy link
Contributor

@sebasguts sebasguts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

Note that this changes some things, and might cause some problems with JuliaExperimental.

How do we want to proceed: Change a lot in JuliaInterface and then make JuliaExperimental catch up later?

@ThomasBreuer what do you think?

JuliaInterface/gap/JuliaInterface.gi Outdated Show resolved Hide resolved
@fingolfin
Copy link
Member Author

My personal stance on this is this: This PR updates the existing tests for JuliaExperimental, so code covered by that is fine. All the other code in JuliaExperimental has a high chance of already being completely broken anyway. IMHO the only way to effectively move on with this project is that for all code, we either add comprehensive tests (then whoever makes changes has a chance of discovering anything they break, and subsequently can fix it), or else we remove that code eventually.

Copy link
Contributor

@sebasguts sebasguts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but some tests are failing. Should I correct them?

@ThomasBreuer
Copy link
Member

@sebasguts Yes, merging proposed changes in JuliaInterface is fine, independent of what they do with JuliaExperimental.
@fingolfin Adjusting tests in JuliaExperimental to changes in JuliaInterface is perhaps not recommended in general; the code is experimental, and it may well be that changes in JuliaInterface make bigger changes in JuliaExperimental sensible.

... for consistency in the auto-conversion behaviour of JuliaInterface versus
LibGAP.jl, and for ease of use.

There is more work to be done here, though, and we need to properly
document the rules for when and where which conversion is applied,
and why.
@fingolfin
Copy link
Member Author

Those test failures were real bugs, yay to the new tests that helped uncover them before merging!

@ThomasBreuer of course I am assuming that any adjustment to JuliaExperimental tests would involve some reasonable thinking, and questioning of what is there. Still, for tests to be most effective, it is important that they all pass (resp. that tests which are expected to fail are marked as such).

@sebasguts sebasguts merged commit 55cce99 into oscar-system:master Nov 6, 2018
@fingolfin fingolfin deleted the mh/gap_julia_gap branch November 6, 2018 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants