-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move arith.gi to JuliaInterface; add methods for EQ and LT, add some tests #132
Conversation
... for consistency in the auto-conversion behaviour of JuliaInterface versus LibGAP.jl, and for ease of use. There is more work to be done here, though, and we need to properly document the rules for when and where which conversion is applied, and why.
These are convenience helpers, it seems plausible to always load them, just like we do with their counterparts written in Julia (in LibGAP.jl)
Codecov Report
@@ Coverage Diff @@
## master #132 +/- ##
==========================================
- Coverage 54.33% 54.28% -0.05%
==========================================
Files 44 44
Lines 2632 2590 -42
==========================================
- Hits 1430 1406 -24
+ Misses 1202 1184 -18
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aprroving this for now, as I think all the changes are good and concerns were adressed in #127.
About ariths.gi
: I would really rather move this functionality into the c code. Do you see any obstacles with it?
I don't see an obstacle, but I am also not sure how much of an advantage there is. Would be useful to at least benchmark it, to get an idea. That said, I really think that all these convenience functions should not be used by code that wants highest performance: If you need to add a million Julia objects, don't write a GAP loop using GAP's wrapper around Julia's The advantage of keeping the code in GAP then is that it is very easy to debug and maintain there, and also to add new mappings. So, if I may make a recommendation, I'd leave |
Agreed. |
Contains PR #127