-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
in show, use StringView not String #248
in show, use StringView not String #248
Conversation
Codecov Report
@@ Coverage Diff @@
## master #248 +/- ##
=======================================
Coverage 70.07% 70.07%
=======================================
Files 50 50
Lines 3262 3262
=======================================
Hits 2286 2286
Misses 976 976
|
One of the Travis tests failed, due to a change of a type name in AbstractAlgebra: |
@ThomasBreuer: Yes, maybe this is a good idea for the moment. |
@mohamed-barakat For the future, I would still like to have some check whether a Julia object created in a specific conversion is reasonable. For example, a matrix |
I was unaware of |
I rebased this PR locally and it works perfectly for me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved once rebased.
May I resolve by rebasing and force-pushing? |
cf9fd94
to
47d8aa2
Compare
47d8aa2
to
b06161e
Compare
I think that the
show
method for GAP objects fits better to GAP'sViewObj
than toString
.Ideally,
ViewString
should be called but this is not (yet) supported for enough GAP objects.Thus
StringView
is a reasonable temporary alternative.(Cf. gap-packages/JupyterKernel#104.)