Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add REPL as package dependency #253

Merged
merged 3 commits into from
Jun 17, 2019
Merged

Conversation

fingolfin
Copy link
Member

That should fix the Travis build failures with Julia nightlies

@codecov
Copy link

codecov bot commented Jun 16, 2019

Codecov Report

Merging #253 into master will decrease coverage by 21.24%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #253       +/-   ##
===========================================
- Coverage   90.81%   69.56%   -21.25%     
===========================================
  Files           4       49       +45     
  Lines         381     3276     +2895     
===========================================
+ Hits          346     2279     +1933     
- Misses         35      997      +962
Impacted Files Coverage Δ
pkg/GAPJulia/JuliaExperimental/gap/gapnemo.gi 96.55% <0%> (ø)
pkg/GAPJulia/JuliaExperimental/gap/zlattice.g 18.75% <0%> (ø)
pkg/GAPJulia/JuliaInterface/gap/BindCFunction.gi 79.16% <0%> (ø)
pkg/GAPJulia/JuliaExperimental/gap/zmodnz.g 97.8% <0%> (ø)
pkg/GAPJulia/JuliaExperimental/gap/hnf.g 100% <0%> (ø)
pkg/GAPJulia/JuliaInterface/gap/BindCFunction.gd 100% <0%> (ø)
pkg/GAPJulia/JuliaExperimental/gap/gapnemo.gd 100% <0%> (ø)
pkg/GAPJulia/JuliaExperimental/julia/numfield.jl 29.41% <0%> (ø)
pkg/GAPJulia/JuliaInterface/gap/JuliaInterface.gd 100% <0%> (ø)
pkg/GAPJulia/JuliaInterface/julia/gaptypes.jl 100% <0%> (ø)
... and 38 more

@mohamed-barakat
Copy link
Contributor

The commit looks good, but Travis seems to have failed again?

@fingolfin
Copy link
Member Author

Yes, more changes are needed. And in fact, I am not so sure the change in this PR is needed / necessary either. It does not really help, in any case. My next best guess comes from JuliaLang/PackageCompiler.jl#194 where a similar error appears, and there, it was worked around by setting JULIA_LOAD_PATH. So I wonder if perhaps in Julia nightlies, when loading Julia from within GAP, it somehow fails to "find itself", i.e., the julia directory with the stdlib/REPL/ subdir in it...

@fingolfin fingolfin force-pushed the mh/REPL branch 2 times, most recently from db8f8cf to bc90c46 Compare June 16, 2019 22:31
@fingolfin
Copy link
Member Author

It seems that for the nightly builds, a completely wrong version of GAP.jl is being tested, so any change I make here has no effect there. I am fiddling around in the hopes of finding a way to resolve that.

That should fix the Travis build failures with Julia nightlies
Copy link
Contributor

@sebasguts sebasguts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you :)

@sebasguts sebasguts merged commit 77d78b9 into oscar-system:master Jun 17, 2019
@fingolfin fingolfin deleted the mh/REPL branch June 17, 2019 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants