-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add REPL as package dependency #253
Conversation
Codecov Report
@@ Coverage Diff @@
## master #253 +/- ##
===========================================
- Coverage 90.81% 69.56% -21.25%
===========================================
Files 4 49 +45
Lines 381 3276 +2895
===========================================
+ Hits 346 2279 +1933
- Misses 35 997 +962
|
The commit looks good, but Travis seems to have failed again? |
Yes, more changes are needed. And in fact, I am not so sure the change in this PR is needed / necessary either. It does not really help, in any case. My next best guess comes from JuliaLang/PackageCompiler.jl#194 where a similar error appears, and there, it was worked around by setting |
db8f8cf
to
bc90c46
Compare
It seems that for the nightly builds, a completely wrong version of GAP.jl is being tested, so any change I make here has no effect there. I am fiddling around in the hopes of finding a way to resolve that. |
That should fix the Travis build failures with Julia nightlies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you :)
That should fix the Travis build failures with Julia nightlies