Misc changes, preparation for PR #249 #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #255 +/- ##
==========================================
+ Coverage 69.95% 69.96% +<.01%
==========================================
Files 49 49
Lines 3258 3259 +1
==========================================
+ Hits 2279 2280 +1
Misses 979 979
|
|
I rebased this PR on the current master in order to make travis tests pass. Once this is done, we can merge it. |
sebasguts
approved these changes
Jun 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In trying to understand what's going on in PR #249, I factored out some of the changes there. A few more will come later, in a separate PR.
I will now also rebase @sebasguts's PR #249 on this.