GAP.AssignGlobalVariable: allow non-mptr arguments #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebasguts
reviewed
Jun 17, 2019
fingolfin
force-pushed
the
mh/AssignGlobalVariable
branch
from
30b6147 to
1eb4d10
Compare
Codecov Report
@@ Coverage Diff @@
## master #258 +/- ##
=========================================
Coverage ? 90.81%
=========================================
Files ? 4
Lines ? 381
Branches ? 0
=========================================
Hits ? 346
Misses ? 35
Partials ? 0 |
fingolfin
force-pushed
the
mh/AssignGlobalVariable
branch
from
1eb4d10 to
9f929af
Compare
fingolfin
force-pushed
the
mh/AssignGlobalVariable
branch
from
9f929af to
6381f63
Compare
sebasguts
approved these changes
Jun 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that just changing the argument type to
Objis not quite enough...This PR is based on PR #255. Once #255 is merged, it can be rebased.