Simplify gap_to_julia code #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #276 +/- ##
==========================================
- Coverage 70.21% 68.99% -1.22%
==========================================
Files 51 54 +3
Lines 3280 3564 +284
==========================================
+ Hits 2303 2459 +156
- Misses 977 1105 +128
|
ThomasBreuer
requested changes
Jul 8, 2019
| translated_obj = gap_to_julia(T,current_obj,recursion_dict) | ||
| dict[ i ] = translated_obj | ||
| recursion_dict[ current_obj ] = translated_obj | ||
| current_obj = getproperty(obj, key) |
There was a problem hiding this comment.
Yes (or rather, the i above should have been key). Fixed now.
- use get! with a do-block to simplify some cases - remove redundant conversions function that allowed for dealing with holes -- they actually did nothing special compared to the base versions (which the still-passing tests seem to confirm)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with holes -- they actually did nothing special compared to
the base versions (which the still-passing tests seem to confirm)