fix access to matrix entries for the GAP master branch #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GAP 4.10 calls the operation `\[\]` with 3 arguments, the master branch calls the new operation `\[\,\]`. Note that the default delegation from `\[\,\]` to `\[\]` does not apply in the given situation because the GAP objects are just Julia objects, without type information about `IsMatrixObj`.
Codecov Report
@@ Coverage Diff @@
## master #279 +/- ##
==========================================
- Coverage 69.05% 68.79% -0.26%
==========================================
Files 54 54
Lines 3564 3580 +16
==========================================
+ Hits 2461 2463 +2
- Misses 1103 1117 +14
|
fingolfin
reviewed
Jul 15, 2019
| #TODO: Remove the installations for '\[\]' and '\[\]\:\=' | ||
| # as soon as a released GAP version supports '\[\,\]' and '\[\,\]\:\='. | ||
| if IsBound( \[\,\] ) then | ||
| InstallOtherMethod( \[\,\], |
There was a problem hiding this comment.
Can't we just install methods for MatElm and SetMatElm? At least that was the theory, that this way one could write the code so that it works with 4.9, 4.10 and 4.11
There was a problem hiding this comment.
Argh, no of course not, and you already explained the reason in your PR description. Sorry about that
fingolfin
approved these changes
Jul 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GAP 4.10 calls the operation
\[\]with 3 arguments,the master branch calls the new operation
\[\,\].Note that the default delegation from
\[\,\]to\[\]does not apply in the given situation because the GAP objects
are just Julia objects, without type information about
IsMatrixObj.(After this change, the tests that were broken after merging #276 should pass again.)