Remove references to ForeignGAP #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #620 +/- ##
=======================================
Coverage 76.63% 76.63%
=======================================
Files 46 46
Lines 3921 3921
=======================================
Hits 3005 3005
Misses 916 916
|
ThomasBreuer
approved these changes
Feb 12, 2021
There was a problem hiding this comment.
Converning GapObj vs. GAP_jll.MPtr:
We use GapObj in several places in the documentation of GAP.jl, and advertise GapObj as a constructor for conversions to GAP.
I think GapObj looks nicer, but users will anyhow have to know about GAP_jll.MPtr since this is what Julia prints.
|
Perhaps then we should use Perhaps you can merge this PR and then (if you feel like it / have time) do such a change? |
|
@fingolfin the suggested change is in pull request #622. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are now gone in the latest master branch. Instead we have
GAP_jll.MPtrandGAP.GapObjis an alias for that (this is slightly annoying, actually, it'd be great if we could "rename" it, but that's for another day to worry about.Perhaps instead of
GAP_jll.MPtrthis PR should use its synonymGAP.GapObj. However, Julia prints that asGAP_jll.MPtr, so I think for the userGAP_jll.MPtrmight be better?