Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mention that GapObj is printed as GAP_jll.MPtr #622

Merged
merged 2 commits into from
Feb 13, 2021

Conversation

ThomasBreuer
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Feb 12, 2021

Codecov Report

Merging #622 (821205d) into master (2ce604b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #622   +/-   ##
=======================================
  Coverage   76.63%   76.63%           
=======================================
  Files          46       46           
  Lines        3921     3921           
=======================================
  Hits         3005     3005           
  Misses        916      916           
Impacted Files Coverage Δ
pkg/JuliaInterface/gap/convert.gd 100.00% <ø> (ø)

Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me. Of course now you could change other mentions of GAP_jll.MPtr to GapObj or GAP.GapObj?

@ThomasBreuer
Copy link
Member Author

Yes.

@fingolfin fingolfin merged commit 7f85f66 into oscar-system:master Feb 13, 2021
@ThomasBreuer ThomasBreuer deleted the TB_GapObj_vs_MPtr branch February 13, 2021 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants