Update OSCAR banner #3410
Update OSCAR banner #3410
Conversation
|
Von meinem iPhone gesendetAm 21.02.2024 um 18:37 schrieb Erik Paemurru ***@***.***>:New banner
banner_new.png (view on web)
Old banner
banner_old.png (view on web)
You can view, comment on, or merge this pull request online at:
#3410
Commit Summary
b1a53be New banner
fc8e2d4 Raw strings to avoid '\' being treated as escaping
File Changes (1 file)
M
src/Oscar.jl
(14)
Patch Links:
https://github.com/oscar-system/Oscar.jl/pull/3410.patch
https://github.com/oscar-system/Oscar.jl/pull/3410.diff
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
|
Much better, thanks!Von meinem iPhone gesendetAm 21.02.2024 um 19:03 schrieb Wolfram Decker ***@***.***>:Von meinem iPhone gesendetAm 21.02.2024 um 18:37 schrieb Erik Paemurru ***@***.***>:New banner
banner_new.png (view on web)
Old banner
banner_old.png (view on web)
You can view, comment on, or merge this pull request online at:
#3410
Commit Summary
b1a53be New banner
fc8e2d4 Raw strings to avoid '\' being treated as escaping
File Changes (1 file)
M
src/Oscar.jl
(14)
Patch Links:
https://github.com/oscar-system/Oscar.jl/pull/3410.patch
https://github.com/oscar-system/Oscar.jl/pull/3410.diff
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
fingolfin
added
the
backport 1.0.x
|
Please adapt the example output in the README.md file as well. |
|
Since we always call OSCAR from Julia, I thought perhaps it is nice to match the OSCAR banner style with Julia's, what do you think? |
|
I would be in favour of option # 3, if this is a vote. (Or anything else that at least partially resembles the "actual" logo from the website.) |
|
I must have missed the discussion, where we decided that we want to update the banner. Since other stakeholders might have an opinion, we can quickly discuss it tomorrow. |
While it is possible to have Julia syntax highlighting in REPL (terminal or command line) using for example OhMyREPL, the first-time user will probably not have this.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3410 +/- ##
==========================================
+ Coverage 81.89% 81.90% +0.01%
==========================================
Files 561 561
Lines 75125 75111 -14
==========================================
Hits 61523 61523
+ Misses 13602 13588 -14
|
|
Added more similarity with the OSCAR logo from the website. |
|
While we are taking the Julia banner as inspiration, it might be a nice idea to also add a link to the Oscar documentation along the Oscar banner. |
|
I don't care much, but let me point out that one issue with the Julia banner is that it doesn't work well if the terminal width is below a certain threshold (there is even a PR for this: JuliaLang/julia#51811). While the same holds for our current banner but the threshold is much smaller. Don't take this as an objection, just as something to be considered. |
src/Oscar.jl
Outdated
| println() | ||
| println("Type: '?Oscar' for more information") | ||
| println("(c) 2019-2024 by The OSCAR Development Team") | ||
| println(raw" ___ ____ ____ _ _.__ ") |
There was a problem hiding this comment.
Shouldn't the first line also have the | if you want to match Julia? And no trailing whitespace?
| println(raw" ___ ____ ____ _ _.__ ") | |
| println(raw" ___ ____ ____ _ _.__ |") |
There was a problem hiding this comment.
Actually, the first line in the Julia banner just consists of the underscore character! To match it, I have made that the first line in the OSCAR banner consists of only underscore characters
Co-authored-by: Max Horn <[email protected]>
src/Oscar.jl
Outdated
| / | \/ ___| / ___| / \ | |_ \ | Type "?Oscar" for more information | ||
| | | | \_|_ \| | / . \ | |_) | | Manual: https://docs.oscar-system.org | ||
| | |_| |___) | |___ / /_\ \| |_ < | | ||
| \_|_/\____/ \____/_/ _ \_\_| \_\ | Version """ * $VERSION_NUMBER) |
There was a problem hiding this comment.
You have to enclose version number in string
| \_|_/\____/ \____/_/ _ \_\_| \_\ | Version """ * $VERSION_NUMBER) | |
| \_|_/\____/ \____/_/ _ \_\_| \_\ | Version """ * "$VERSION_NUMBER") |
|
Looks like this now |
|
If this an ASCII art design competition I want to chuck in: It's one line higher (and a few characters wider), but I think the S looks better with the extra line. |
|
Together with the rest of the banner text, the design by @joschmitt does not fit in a 80-character width terminal, which is a big down-side |
Yeah, I think the "fine-print" can also come below the logo. But yes, if we want to go full julia-style this doesn't work. |
Co-authored-by: Lars Göttgens <[email protected]>
|
Removed top row dot character as recommended by @lgoettgens |
|
To my eyes the current (old) banner is the worst: all the newer proposals are better! |
@paemurru will create a poll in this thread. |
Despite reading the corresponding message on slack, I am uncertain how the vote is supposed to work. So... I like Thank you for working on this! (I agree with @JohnAAbbott. Also to my eyes, the vertical lines in the third banner look like "something went wrong" in the ASCII art version.) |
|
@HereAround Thank you! I would not have noticed myself that the vertical lines look odd. How to vote: at the end of the first post of this pull request, there is a button to add a reaction. |
|
After looking again at the two julia like designs, I believe that the O and/or the distance to the S are too small. Von meinem iPhone gesendetAm 24.02.2024 um 11:32 schrieb Erik Paemurru ***@***.***>:
@HereAround Thank you! I would not have noticed myself that the vertical lines look odd.
How to vote: at the end of the first post of this pull request, there is a button to add a reaction.
scrn1.b.png (view on web)
To vote, put a reaction according to which banner you wish to vote for.
scrn2.b.png (view on web)
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>
|
|
Just for reference, a similar question and a lot of banner-handling code is being discussed for julia itself: JuliaLang/julia#51811 In particular, the new StyledStrings standard library can be pretty helpful. |
|
Increased spacing between O and S according to suggestion by @wdecker. Added a one-line banner for small terminals (width less than 79 characters) |
* New banner * Raw strings to avoid '\' being treated as escaping * figlet style OSCAR banner, update README.md * Remove README.md julia syntax color While it is possible to have Julia syntax highlighting in REPL (terminal or command line) using for example OhMyREPL, the first-time user will probably not have this. * More similarity to logo from website * Triple quoted string, manual link, text to top row Co-authored-by: Max Horn <[email protected]> * Fix string, remove text from top line * Remove dot from top row in README.md Co-authored-by: Lars Göttgens <[email protected]> * Remove dot from top row in Oscar.jl * Banner without vertical bars inside the letters * Increase distance between O and S * Print one-line banner for small terminals --------- Co-authored-by: Max Horn <[email protected]> Co-authored-by: Lars Göttgens <[email protected]>
--------- Co-authored-by: Max Horn <[email protected]> Co-authored-by: Lars Göttgens <[email protected]> (cherry picked from commit f468cca)
aaruni96
removed
the
backport 1.0.x
- Add QQBar docs to the manual #3423 - do not show the OscarInterface banner #3422 - fix bugs in all_OD_infos #3419 - Ep/ Rename Spec to AffineScheme #3345 #3425 - Remove two mentions of Arb_jll #3431 - Tweak epimorphism_from_free_group #3430 - CI: re-enable nightly #3435 - support gen(G::GAPGroup, 0) #3332 - Align all_*_groups methods some more #3433 - Add all_perfect_groups #3434 - Add all_primitive_groups and all_transitive_groups variants taking a single int or int range #3404 - fix a docstring #3436 - Fixes multivariate division #3396 - Docu invariants tori #3428 - Improve docstrings for is_conjugate/is_conjugate_with_data. #3384 - Fix ambient_module(M::SubquoModule) #3448 - Bugfix for printing of affine schemes #3437 - Bugfix for bugfix for printing of affine schemes #3445 - Update OSCAR banner #3410 - Docu invariants lin. red. groups (Lakshmi Ramesh and Wolfram Decker) #3443 - add od_from_atlas_group, od_from_p_subgroup, and helpers #3444 - Unexport normalise #3453 - support group properties for character tables #3449 - add docstrings for acting_group and action_function #3432 (exports are used in new groups code for the book) - Adjust to renaming of rank(A::FinGenAbGroup) to torsion_free_rank(A::FinGenAbGroup) #3457 - Ensure fp_group(G) transfers group attributes #3464 - Added comment on convention #3467 - Export weierstrass_chart_on_minimal_model and patch transform_to_weierstrass #3458 - Fix a doc signature #3466 - Grading + caching for affine algebra of torus invariants #3469
In today's OSCAR meeting it was decided to decide by Monday which banner to use. Use the corresponding reaction to vote.
😄 Original OSCAR banner
🎉 Very slight change
🚀 Julia-style, letters have vertical bars like in the current OSCAR logo (according to the meeting, the current OSCAR logo might change soon)
❤️ Julia-style, clean version with no vertical bars
