Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for bugfix for printing of affine schemes #3445

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Conversation

thofma
Copy link
Collaborator

@thofma thofma commented Feb 27, 2024

Turns

julia> [Spec(L)]
1-element Vector{AffineScheme{QQField, Oscar.MPolyLocRing{QQField, QQFieldElem, QQMPolyRing, QQMPolyRingElem, Oscar.MPolyPowersOfElement{QQField, QQFieldElem, QQMPolyRing, QQMPolyRingElem}}}}:
AA^2 \ scheme((x)*(y)*(x*y))

into

julia> [Spec(L)]
1-element Vector{AffineScheme{QQField, Oscar.MPolyLocRing{QQField, QQFieldElem, QQMPolyRing, QQMPolyRingElem, Oscar.MPolyPowersOfElement{QQField, QQFieldElem, QQMPolyRing, QQMPolyRingElem}}}}:
AA^2 \ scheme(x*y*x*y)

I dedicate this to Dan S., who taught us to avoid parentheses like never before.

Copy link
Collaborator

@HechtiDerLachs HechtiDerLachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I have little idea of what's really happening in the background, but I am leaning towards trusting you and @tthsqe12 on their good work. With the missing bracket added, maybe we do not even need to fix the doctests.

Edit: It seems that I don't have the right to push to this pr. I will leave a suggestion, then.

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Merging #3445 (be410c3) into master (2a87512) will increase coverage by 0.00%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3445   +/-   ##
=======================================
  Coverage   81.92%   81.93%           
=======================================
  Files         561      561           
  Lines       75177    75175    -2     
=======================================
+ Hits        61588    61592    +4     
+ Misses      13589    13583    -6     
Files Coverage Δ
...cGeometry/Schemes/AffineSchemes/Objects/Methods.jl 94.54% <100.00%> (+3.52%) ⬆️

... and 1 file with indirect coverage changes

Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. Can/should this be backported? (I don't know if it affects the book)

@HechtiDerLachs
Copy link
Collaborator

Yes, I think it should be backported. At least #3437 must be backported, since the output is just wrong. Then this one doesn't seem to hurt on top of it.

@fingolfin fingolfin added the backport 1.0.x Should be backported to the release 1.0 branch label Feb 28, 2024
@fingolfin fingolfin merged commit 62d3c12 into master Feb 28, 2024
27 checks passed
@fingolfin fingolfin deleted the th/affprint branch February 28, 2024 09:46
benlorenz pushed a commit that referenced this pull request Feb 28, 2024
@benlorenz benlorenz mentioned this pull request Feb 28, 2024
31 tasks
@benlorenz benlorenz removed the backport 1.0.x Should be backported to the release 1.0 branch label Feb 28, 2024
@HechtiDerLachs HechtiDerLachs added the backport 1.0.x Should be backported to the release 1.0 branch label Feb 28, 2024
mjrodgers pushed a commit to mjrodgers/Oscar.jl that referenced this pull request Feb 28, 2024
@benlorenz benlorenz removed the backport 1.0.x Should be backported to the release 1.0 branch label Feb 29, 2024
benlorenz added a commit that referenced this pull request Feb 29, 2024
- Add QQBar docs to the manual #3423
- do not show the OscarInterface banner #3422
- fix bugs in all_OD_infos #3419
- Ep/ Rename Spec to AffineScheme #3345 #3425
- Remove two mentions of Arb_jll #3431
- Tweak epimorphism_from_free_group #3430
- CI: re-enable nightly #3435
- support gen(G::GAPGroup, 0) #3332
- Align all_*_groups methods some more #3433
- Add all_perfect_groups #3434
- Add all_primitive_groups and all_transitive_groups variants taking a single int or int range #3404
- fix a docstring #3436
- Fixes multivariate division #3396
- Docu invariants tori #3428
- Improve docstrings for is_conjugate/is_conjugate_with_data. #3384
- Fix ambient_module(M::SubquoModule) #3448
- Bugfix for printing of affine schemes #3437
- Bugfix for bugfix for printing of affine schemes #3445
- Update OSCAR banner #3410
- Docu invariants lin. red. groups (Lakshmi Ramesh and Wolfram Decker) #3443
- add od_from_atlas_group, od_from_p_subgroup, and helpers #3444
- Unexport normalise #3453
- support group properties for character tables #3449
- add docstrings for acting_group and action_function #3432 (exports are used in new groups code for the book)
- Adjust to renaming of rank(A::FinGenAbGroup) to torsion_free_rank(A::FinGenAbGroup) #3457
- Ensure fp_group(G) transfers group attributes #3464
- Added comment on convention #3467
- Export weierstrass_chart_on_minimal_model and patch transform_to_weierstrass #3458
- Fix a doc signature #3466
- Grading + caching for affine algebra of torus invariants #3469
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants